[WIP] Script to embedder communication #20706

gterzian · 2018-04-28T08:33:33Z

Following the pattern of ScriptToConstellationChan.

This change is

highfive · 2018-04-28T08:33:37Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/pipeline.rs, components/script/dom/globalscope.rs, components/constellation/constellation.rs, components/script/script_thread.rs, components/script/dom/window.rs
@cbrewster: components/constellation/pipeline.rs, components/constellation/constellation.rs
@paulrouget: components/constellation/pipeline.rs, components/constellation/constellation.rs
@fitzgen: components/script/dom/globalscope.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs
@KiChjang: components/script/dom/globalscope.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs

highfive · 2018-04-28T08:33:38Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!


        script to embedder chan

gterzian · 2018-04-28T14:53:39Z

In favor of #20707

gterzian · 2018-04-28T15:04:25Z

components/script_traits/lib.rs

+
+/// A Script to Embedder channel.
+#[derive(Clone, Deserialize, Serialize)]
+pub struct ScriptToEmbedderChan {


This is not necessary, since top_level_browsing_context_id would available directly at the point where could be used to send an EmbedderMsg...

highfive assigned emilio Apr 28, 2018

highfive added the S-awaiting-review label Apr 28, 2018

gterzian changed the title ~~[WIP] Script to embedder comminication~~ [WIP] Script to embedder communication Apr 28, 2018

script to embedder chan

Loading status checks…

3ea8ecf

gterzian force-pushed the gterzian:embedder_handling_of_prompts_and_alerts branch from 4f1e1dd to 3ea8ecf Apr 28, 2018

gterzian closed this Apr 28, 2018

gterzian reviewed Apr 28, 2018

View changes

gterzian deleted the gterzian:embedder_handling_of_prompts_and_alerts branch Jan 7, 2020

servo / servo