Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically provide a resource reader for tests #20718

Merged
merged 1 commit into from May 18, 2018
Merged

Automatically provide a resource reader for tests #20718

merged 1 commit into from May 18, 2018
+72 −109

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Apr 30, 2018 •
edited by SimonSapin

Fix #20710

  • ./mach build -d does not report any errors
  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20710 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@paulrouget
Automatically provide a resource reader for tests
Loading status checks…
e02a23b
@highfive
Copy link

highfive commented Apr 30, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml, components/script/Cargo.toml
  • @cbrewster: components/constellation/Cargo.toml
  • @fitzgen: components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/tests/pub_domains.rs, components/script/Cargo.toml, components/net/tests/cookie.rs and 2 more
@paulrouget paulrouget requested a review from emilio Apr 30, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Apr 30, 2018

r? @emilio
@highfive highfive assigned emilio and unassigned nox Apr 30, 2018
@emilio
emilio approved these changes May 11, 2018
View changes
Copy link
Member

emilio left a comment

Looks great, thank you!
@emilio
Copy link
Member

emilio commented May 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2018

📌 Commit e02a23b has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2018

⌛ Testing commit e02a23b with merge 2b2508b...
bors-servo added a commit that referenced this pull request May 11, 2018
@bors-servo
Auto merge of #20718 - paulrouget:res2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b2508b 
Automatically provide a resource reader for tests

Fix #20710

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20710 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo retry p=10
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

⌛ Testing commit e02a23b with merge 17a6ae2...
bors-servo added a commit that referenced this pull request May 18, 2018
@bors-servo
Auto merge of #20718 - paulrouget:res2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17a6ae2 
Automatically provide a resource reader for tests

Fix #20710

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20710 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit...
@bors-servo bors-servo mentioned this pull request May 18, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

⌛ Testing commit e02a23b with merge 67370b3...
bors-servo added a commit that referenced this pull request May 18, 2018
@bors-servo
Auto merge of #20718 - paulrouget:res2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67370b3 
Automatically provide a resource reader for tests

Fix #20710

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20710 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 67370b3 to master...
@bors-servo bors-servo merged commit e02a23b into servo:master May 18, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Unit tests that read prefs can randomly panic.
6 participants
@paulrouget @highfive @emilio @bors-servo @jdm @nox
You can’t perform that action at this time.