Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(window): set enter key as non-printable char #20727
Closed
Conversation
highfive
commented
May 1, 2018
|
Heads up! This PR modifies the following files:
|
|
Having proper IME support would help solve these kind of issues. |
|
|
|
Let me close this as upstream has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kwonoj commentedMay 1, 2018
•
edited by SimonSapin
Mostly for discussion around #20630, #20726.
If this PR's accepted & merged, it may serve as temporal workaround only.
This PR changes behavior of
windowto consider ENTER key as non-printable, let document does not appends redundant carriage return when press enter on textinput field. But this PR instead omitskeypressevent onEnterlikewhile other browsers does emit

makes me feel proper fix would be something like #20726, revise flow to send over keyevent to document itself.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is