Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement border-image-outset #20739

Merged
merged 1 commit into from May 3, 2018
Merged

Conversation

@pyfisch
Copy link
Contributor

pyfisch commented May 2, 2018

Add an automatic test for border-image-outset with a gradient.
Convert two tests from UTF-8 LE with CRLF line endings to
UTF-8 with LF endings as the old files could not be viewed with servo.

Closes #16638


This change is Reviewable

Add an automatic test for border-image-outset with a gradient.
Convert two tests from UTF-8 LE with CRLF line endings to
UTF-8 with LF endings as the old files could not be viewed with servo.

Closes #16638
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 2, 2018

Error syncing changes upstream. Logs saved in error-snapshot-1525293454382.

@highfive
Copy link

highfive commented May 2, 2018

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list/builder.rs, components/layout/display_list/background.rs
@pyfisch
Copy link
Contributor Author

pyfisch commented May 2, 2018

Note that not all border gradients can be expressed with current webrender: servo/webrender#1875

@pyfisch
Copy link
Contributor Author

pyfisch commented May 2, 2018

bors-servo added a commit that referenced this pull request May 2, 2018
Implement border-image-outset

Add an automatic test for border-image-outset with a gradient.
Convert two tests from UTF-8 LE with CRLF line endings to
UTF-8 with LF endings as the old files could not be viewed with servo.

Closes #16638

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20739)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

Trying commit 7eff53e with merge ac13d70...

@jdm
Copy link
Member

jdm commented May 2, 2018

@highfive highfive assigned mbrubeck and unassigned jdm May 2, 2018
@mbrubeck
Copy link
Contributor

mbrubeck commented May 2, 2018

@bors-servo try- r+ retry

@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

📌 Commit 7eff53e has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

Testing commit 7eff53e with merge eda5978...

bors-servo added a commit that referenced this pull request May 2, 2018
Implement border-image-outset

Add an automatic test for border-image-outset with a gradient.
Convert two tests from UTF-8 LE with CRLF line endings to
UTF-8 with LF endings as the old files could not be viewed with servo.

Closes #16638

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20739)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2018

@bors-servo bors-servo merged commit 7eff53e into servo:master May 3, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pyfisch pyfisch deleted the pyfisch:border-image-outset branch May 3, 2018
jdm added a commit to web-platform-tests/wpt that referenced this pull request May 4, 2018
Add an automatic test for border-image-outset with a gradient.
Convert two tests from UTF-8 LE with CRLF line endings to
UTF-8 with LF endings as the old files could not be viewed with servo.

Closes #16638

Upstreamed from servo/servo#20739 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.