Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(capture_webrender): try fallback capture dir #20750
Conversation
highfive
commented
May 4, 2018
|
Heads up! This PR modifies the following files:
|
|
Any reason to not always save under a temp directory? Otherwise, lgtm. |
Mostly I felt it's somewhat easier to explain to ppl - such as run servo you just downloaded by click in explorer (finder, or else), capture, you'll see new dir generated vs. please try to traverse down TMPDIR based on your platform. Other than those, no strong reason. |
|
@bors-servo r+ |
|
|
fix(capture_webrender): try fallback capture dir <!-- Please describe your changes on the following line: --> This PR try to update behavior of webrender capture to have fallback dir - first it try to create under current working dir, if fails go back to $TMPDIR. I was debating between TMP vs $home, bit hesitate to create some folder under user's home dir directly so choose TMP instead. Can be easily changed, or add few more if needed. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20746 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ - locally verified on mac os <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20750) <!-- Reviewable:end -->
|
@bors-servo treeclosed=8000 |
|
|
|
@bors-servo treeclosed- |
|
@bors-servo treeclosed=8000 |
|
Can't do that in an already-merged PR. |
kwonoj commentedMay 4, 2018
•
edited by SimonSapin
This PR try to update behavior of webrender capture to have fallback dir - first it try to create under current working dir, if fails go back to $TMPDIR. I was debating between TMP vs $home, bit hesitate to create some folder under user's home dir directly so choose TMP instead. Can be easily changed, or add few more if needed.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is