style: Some animation cleanups and fixes. #20757

emilio · 2018-05-06T16:48:47Z

The transitions code is still terribly broken, but I ran out of time fixing it. We have nothing that stops transitions, which is just plain wrong. Most of this code should probably be rewritten, since with the current setup is pretty hard to get it right. Anyway...

Fixes #20731.
Fixes #20116.

This change is

highfive · 2018-05-06T16:48:51Z

Heads up! This PR modifies the following files:

@bholley: components/style/matching.rs, components/style/animation.rs, components/style/properties/helpers/animated_properties.mako.rs
@canaltinova: components/style/matching.rs, components/style/animation.rs, components/style/properties/helpers/animated_properties.mako.rs

highfive · 2018-05-06T16:48:53Z

Warning

These commits modify style and layout code, but no tests are modified. Please consider adding a test!

emilio · 2018-05-06T16:53:18Z

r? @nox or @SimonSapin or @mbrubeck

emilio · 2018-05-07T06:36:15Z

@bors-servo try

bors-servo · 2018-05-07T06:36:22Z

⌛ Trying commit 31ffd84 with merge 458a54c...


        Auto merge of #20757 - emilio:animations, r=<try>

style: Some animation cleanups and fixes. The transitions code is still terribly broken, but I ran out of time fixing it. We have nothing that stops transitions, which is just plain wrong. Most of this code should probably be rewritten, since with the current setup is pretty hard to get it right. Anyway... Fixes #20731. Fixes #20116.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20757)

bors-servo · 2018-05-07T07:02:41Z

💔 Test failed - linux-rel-css

CYBAI · 2018-05-07T12:25:17Z

In linux-rel-css:

{"status": "FAIL", "group": "default", "message": "assert_in_array: color is green after transition runs value \"rgb(0, 0, 255)\" not in array [\"rgb(0, 128, 0)\", \"rgba(0, 128, 0, 1)\"]", "stack": "@http://web-platform.test:8000/css/css-variables/variable-transitions-transition-property-all-before-value.html:59:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1490:20\nTest.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1530:17\n", "subtest": "Verify substituted color value after transition", "test": "/css/css-variables/variable-transitions-transition-property-all-before-value.html", "line": 40081, "action": "test_result", "expected": "PASS"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "font-style animation", "test": "/css/css-fonts/variations/font-style-interpolation.html", "line": 60956, "action": "test_result", "expected": "TIMEOUT"}
{"status": "TIMEOUT", "group": "default", "message": "Test timed out", "stack": null, "subtest": "font-style transition", "test": "/css/css-fonts/variations/font-style-interpolation.html", "line": 60957, "action": "test_result", "expected": "PASS"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "font-weight animation", "test": "/css/css-fonts/variations/font-weight-interpolation.html", "line": 104452, "action": "test_result", "expected": "TIMEOUT"}
{"status": "FAIL", "group": "default", "message": "assert_in_array: color is green after transition runs value \"rgb(0, 0, 255)\" not in array [\"rgb(0, 128, 0)\", \"rgba(0, 128, 0, 1)\"]", "stack": "@http://web-platform.test:8000/css/css-variables/variable-transitions-value-before-transition-property-all.html:58:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1490:20\nTest.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1530:17\n", "subtest": "Verify substituted color value after transition", "test": "/css/css-variables/variable-transitions-value-before-transition-property-all.html", "line": 115469, "action": "test_result", "expected": "PASS"}

In mac-rel-wpt4:

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "font-style animation", "test": "/css/css-fonts/variations/font-style-interpolation.html", "line": 22039, "action": "test_result", "expected": "TIMEOUT"}
{"status": "TIMEOUT", "group": "default", "message": "Test timed out", "stack": null, "subtest": "font-style transition", "test": "/css/css-fonts/variations/font-style-interpolation.html", "line": 22040, "action": "test_result", "expected": "PASS"}
{"status": "NOTRUN", "group": "default", "message": null, "stack": null, "subtest": "Overall test", "test": "/_mozilla/webgl/conformance-1.0.3/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html", "line": 90995, "action": "test_result", "expected": "PASS"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/webgl/conformance-1.0.3/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html", "line": 91012, "action": "test_result", "expected": "OK"}

gootorov · 2018-05-08T19:19:27Z

components/style/animation.rs

@@ -207,7 +207,7 @@ pub enum Animation {
    /// the f64 field is the start time as returned by `time::precise_time_s()`.
    ///
    /// The `bool` field is werther this animation should no longer run.


Don't forget to remove this line too.

nox · 2018-05-10T07:35:14Z

components/style/properties/helpers/animated_properties.mako.rs

-                % endif
+            % if prop.animatable:
+            AnimatedProperty::${prop.camel_case}(..) => LonghandId::${prop.camel_case},
+            % endif


I wonder if AnimatedProperty should use the same trick as AnimationValue to just read the discriminant value as the LonghandId result.

fabricedesre · 2018-05-30T17:36:04Z

@emilio do you need help pushing that to the finish line?

bors-servo · 2018-07-24T12:03:36Z

☔ The latest upstream changes (presumably #21237) made this pull request unmergeable. Please resolve the merge conflicts.


        style: Cleanup some of the animation starting code.


        style: Make the transitions code make sense again.


        style: Remove unused expired boolean in Animation::Transition.

The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all.


        style: Expire keyframes animations when no longer referenced by the s…

…tyle. It's a long way to make this sound in general... Fixes #20731

emilio · 2018-10-15T02:53:26Z

@bors-servo try


        Auto merge of #20757 - emilio:animations, r=<try>

style: Some animation cleanups and fixes. The transitions code is still terribly broken, but I ran out of time fixing it. We have nothing that stops transitions, which is just plain wrong. Most of this code should probably be rewritten, since with the current setup is pretty hard to get it right. Anyway... Fixes #20731. Fixes #20116.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20757)

bors-servo · 2018-10-15T02:53:31Z

⌛ Trying commit 7979b25 with merge c1a3d7e...

bors-servo · 2018-10-15T23:03:11Z

⌛ Testing commit 561e9c8 with merge 3b03f6d...


        Auto merge of #20757 - emilio:animations, r=jdm

style: Some animation cleanups and fixes. The transitions code is still terribly broken, but I ran out of time fixing it. We have nothing that stops transitions, which is just plain wrong. Most of this code should probably be rewritten, since with the current setup is pretty hard to get it right. Anyway... Fixes #20731. Fixes #20116.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20757)

bors-servo · 2018-10-16T00:14:27Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 3b03f6d to master...


        Bug 1500260 - Cleanup some of the animation starting code. r=emilio

This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Remove unused expired boolean in Animation::Transition.…

… r=emilio The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all. This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Expire keyframes animations when no longer referenced b…

…y the style. r=emilio It's a long way to make this sound in general... Fixes #20731 This cherry-picks part of servo/servo#20757.


        Bug 1500260 - More useful logging for transition-related stuff. r=emilio

Transitions are still broken, but I found these messages more helpful than the previous ones when diagnosing problems. This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Cleanup some of the animation starting code. r=emilio

This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Remove unused expired boolean in Animation::Transition.…

… r=emilio The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all. This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Expire keyframes animations when no longer referenced b…

…y the style. r=emilio It's a long way to make this sound in general... Fixes #20731 This cherry-picks part of servo/servo#20757.


        Bug 1500260 - More useful logging for transition-related stuff. r=emilio

Transitions are still broken, but I found these messages more helpful than the previous ones when diagnosing problems. This cherry-picks part of servo/servo#20757.


        Bug 1500260 - Cleanup some of the animation starting code. r=emilio

This cherry-picks part of servo/servo#20757. UltraBlame original commit: bfac8c708a3f50ed6cb301548edec21b097c0a7f


        Bug 1500260 - Remove unused expired boolean in Animation::Transition.…

… r=emilio The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 6d0c84abdfa1d1b5e64e78a1826762e110c7ea57


        Bug 1500260 - Expire keyframes animations when no longer referenced b…

…y the style. r=emilio It's a long way to make this sound in general... Fixes #20731 This cherry-picks part of servo/servo#20757. UltraBlame original commit: 7037075929099a8d88ef702257e88d15cbe3ab59


        Bug 1500260 - More useful logging for transition-related stuff. r=emilio

Transitions are still broken, but I found these messages more helpful than the previous ones when diagnosing problems. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 99cc3c6f76ef81913aea6d0a7d785e02e55f4648


        Bug 1500260 - Cleanup some of the animation starting code. r=emilio

This cherry-picks part of servo/servo#20757. UltraBlame original commit: bfac8c708a3f50ed6cb301548edec21b097c0a7f


        Bug 1500260 - Remove unused expired boolean in Animation::Transition.…

… r=emilio The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 6d0c84abdfa1d1b5e64e78a1826762e110c7ea57


        Bug 1500260 - Expire keyframes animations when no longer referenced b…

…y the style. r=emilio It's a long way to make this sound in general... Fixes #20731 This cherry-picks part of servo/servo#20757. UltraBlame original commit: 7037075929099a8d88ef702257e88d15cbe3ab59


        Bug 1500260 - More useful logging for transition-related stuff. r=emilio

Transitions are still broken, but I found these messages more helpful than the previous ones when diagnosing problems. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 99cc3c6f76ef81913aea6d0a7d785e02e55f4648


        Bug 1500260 - Cleanup some of the animation starting code. r=emilio

This cherry-picks part of servo/servo#20757. UltraBlame original commit: bfac8c708a3f50ed6cb301548edec21b097c0a7f


        Bug 1500260 - Remove unused expired boolean in Animation::Transition.…

… r=emilio The last caller who used was #14418, which did fix a problem but introduced multiple. In particular, now transitions don't get expired ever, until they finish running of course. That is not ok, given you can have something that the user can trigger to change the style (hi, :hover, for example), and right now that triggers new transitions, getting this into a really funny state. I should give fixing this a shot, but it's non-trivial at all. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 6d0c84abdfa1d1b5e64e78a1826762e110c7ea57


        Bug 1500260 - Expire keyframes animations when no longer referenced b…

…y the style. r=emilio It's a long way to make this sound in general... Fixes #20731 This cherry-picks part of servo/servo#20757. UltraBlame original commit: 7037075929099a8d88ef702257e88d15cbe3ab59


        Bug 1500260 - More useful logging for transition-related stuff. r=emilio

Transitions are still broken, but I found these messages more helpful than the previous ones when diagnosing problems. This cherry-picks part of servo/servo#20757. UltraBlame original commit: 99cc3c6f76ef81913aea6d0a7d785e02e55f4648

highfive assigned mbrubeck May 6, 2018

highfive added the S-awaiting-review label May 6, 2018

emilio force-pushed the emilio:animations branch from fba4937 to 31ffd84 May 6, 2018

highfive assigned nox and unassigned mbrubeck May 6, 2018

emilio mentioned this pull request May 7, 2018

The `Idle` state is not always reached at the end of css transitions #20379

Closed

highfive added the S-tests-failed label May 7, 2018

gootorov reviewed May 8, 2018

View changes

nox reviewed May 10, 2018

View changes

highfive added the S-needs-rebase label Jul 24, 2018

emilio added 2 commits May 5, 2018

style: Cleanup some of the animation starting code.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

d44bd82

style: Make the transitions code make sense again.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

d6092fa

emilio force-pushed the emilio:animations branch from 31ffd84 to 9f3f438 Oct 15, 2018

highfive removed the S-tests-failed label Oct 15, 2018

emilio added 2 commits May 5, 2018

style: Expire keyframes animations when no longer referenced by the s…

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

a949e9e

…tyle. It's a long way to make this sound in general... Fixes #20731

emilio force-pushed the emilio:animations branch from 9f3f438 to 7979b25 Oct 15, 2018

highfive added the S-awaiting-merge label Oct 15, 2018

bors-servo merged commit 561e9c8 into servo:master Oct 16, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 16, 2018

emilio deleted the emilio:animations branch Oct 16, 2018

atouchet mentioned this pull request Oct 16, 2018

servo.org screenshot pulses in and out #21955

Closed

emilio mentioned this pull request Oct 16, 2018

Evil Ad demo particle animations not working correctly #21956

Closed

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 18, 2018

Bug 1500260 - Cleanup some of the animation starting code. r=emilio

3f29fd8

This cherry-picks part of servo/servo#20757.

xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this pull request Oct 19, 2018

Bug 1500260 - Cleanup some of the animation starting code. r=emilio

0544293

This cherry-picks part of servo/servo#20757.

atouchet mentioned this pull request Mar 3, 2020

Transitions and animations #25884

Closed

servo / servo

style: Some animation cleanups and fixes. #20757

style: Some animation cleanups and fixes. #20757

emilio commented May 6, 2018 •

edited by SimonSapin

highfive commented May 6, 2018

highfive commented May 6, 2018

emilio commented May 6, 2018

emilio commented May 7, 2018

bors-servo commented May 7, 2018

bors-servo commented May 7, 2018

CYBAI commented May 7, 2018

This comment has been minimized.

This comment has been minimized.

fabricedesre commented May 30, 2018

bors-servo commented Jul 24, 2018

emilio commented Oct 15, 2018

bors-servo commented Oct 15, 2018

bors-servo commented Oct 15, 2018

bors-servo commented Oct 16, 2018

servo / servo

Join GitHub today

style: Some animation cleanups and fixes. #20757

style: Some animation cleanups and fixes. #20757

Conversation

emilio commented May 6, 2018 • edited by SimonSapin

highfive commented May 6, 2018

highfive commented May 6, 2018

emilio commented May 6, 2018

emilio commented May 7, 2018

bors-servo commented May 7, 2018

bors-servo commented May 7, 2018

CYBAI commented May 7, 2018

This comment has been minimized.

gootorov May 8, 2018

This comment has been minimized.

nox May 10, 2018

fabricedesre commented May 30, 2018

bors-servo commented Jul 24, 2018

emilio commented Oct 15, 2018

bors-servo commented Oct 15, 2018

bors-servo commented Oct 15, 2018

bors-servo commented Oct 16, 2018

emilio commented May 6, 2018 •

edited by SimonSapin