Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement most of the unsupported parameters in gl.getParameter() #20771

Merged
merged 1 commit into from May 24, 2018
Merged

Implement most of the unsupported parameters in gl.getParameter() #20771

merged 1 commit into from May 24, 2018
+67 −321

Conversation

@nox
Copy link
Member

nox commented May 9, 2018 •
edited by SimonSapin

Fixes #20536.
Fixes #20537.
Fixes #20538.
Fixes #20544.
Fixes #20545.
Fixes #20546.
Fixes #20548.
Fixes #20549.
Fixes #20551.

This change is Reviewable
@highfive
Copy link

highfive commented May 9, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @fitzgen: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented May 9, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox
Copy link
Member Author

nox commented May 9, 2018

r? @emilio
@highfive highfive assigned emilio and unassigned jdm May 9, 2018
@emilio
Copy link
Member

emilio commented May 9, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2018

📌 Commit 92e0050 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2018

⌛ Testing commit 92e0050 with merge eed3ca6...
bors-servo added a commit that referenced this pull request May 9, 2018
@bors-servo
Auto merge of #20771 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eed3ca6 
Implement most of the unsupported parameters in gl.getParameter()

Fixes #20536.
Fixes #20537.
Fixes #20538.
Fixes #20544.
Fixes #20545.
Fixes #20546.
Fixes #20548.
Fixes #20549.
Fixes #20551.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20771)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented May 10, 2018

Does this overlap with #20754?
@jdm
Copy link
Member

jdm commented May 10, 2018

Android build failure that wasn't reported as a buildbot failure:

"/usr/local/bin/virtualenv" "-p" "/usr/bin/python2.7" "--system-site-packages" "/home/servo/buildbot/slave/android/build/python/_virtualenv" failed with error code 1:
Output:
New python executable in /home/servo/buildbot/slave/android/build/python/_virtualenv/bin/python2.7
Not overwriting existing python script /home/servo/buildbot/slave/android/build/python/_virtualenv/bin/python (you must use /home/servo/buildbot/slave/android/build/python/_virtualenv/bin/python2.7)
Running virtualenv with interpreter /usr/bin/python2.7
Error:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 2304, in <module>
    main()
  File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 705, in main
    symlink=options.symlink)
  File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 924, in create_environment
    download=download,
  File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 843, in install_wheel
    cert_data = pkgutil.get_data("pip._vendor.requests", "cacert.pem")
  File "/usr/lib/python2.7/pkgutil.py", line 578, in get_data
    loader = get_loader(package)
  File "/usr/lib/python2.7/pkgutil.py", line 464, in get_loader
    return find_loader(fullname)
  File "/usr/lib/python2.7/pkgutil.py", line 474, in find_loader
    for importer in iter_importers(fullname):
  File "/usr/lib/python2.7/pkgutil.py", line 430, in iter_importers
    __import__(pkg)
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/__init__.py", line 13, in <module>
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/utils/__init__.py", line 26, in <module>
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 3130, in <module>
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 3116, in _call_aside
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 3155, in _initialize_master_working_set
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 956, in subscribe
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 3155, in <lambda>
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 2655, in activate
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 2225, in declare_namespace
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 2194, in _handle_ns
  File "/usr/local/lib/python2.7/dist-packages/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/_vendor/pkg_resources/__init__.py", line 2192, in sort_key
ValueError: '/usr/local/lib/python2.7/dist-packages' is not in list
@nox
Copy link
Member Author

nox commented May 10, 2018

Does this overlap with #20754?

No.
@nox
Copy link
Member Author

nox commented May 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

⌛ Testing commit 92e0050 with merge 99a6406...
bors-servo added a commit that referenced this pull request May 18, 2018
@bors-servo
Auto merge of #20771 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
99a6406 
Implement most of the unsupported parameters in gl.getParameter()

Fixes #20536.
Fixes #20537.
Fixes #20538.
Fixes #20544.
Fixes #20545.
Fixes #20546.
Fixes #20548.
Fixes #20549.
Fixes #20551.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20771)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented May 18, 2018 

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "Overall test", "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html", "line": 167328, "action": "test_result", "expected": "NOTRUN"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html", "line": 167510, "action": "test_result", "expected": "TIMEOUT"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "Overall test", "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/bugs/complex-glsl-does-not-crash.html", "line": 198755, "action": "test_result", "expected": "NOTRUN"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/bugs/complex-glsl-does-not-crash.html", "line": 198817, "action": "test_result", "expected": "TIMEOUT"}
@nox
Copy link
Member Author

nox commented May 24, 2018

I had not even realised that this didn't land yet…
@nox
Implement most of the unsupported parameters in gl.getParameter()
Loading status checks…
3e510ec 
Fixes #20536.
Fixes #20537.
Fixes #20538.
Fixes #20544.
Fixes #20545.
Fixes #20546.
Fixes #20548.
Fixes #20549.
Fixes #20551.
@nox nox force-pushed the webgl branch from 92e0050 to 3e510ec May 24, 2018
@nox
Copy link
Member Author

nox commented May 24, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

📌 Commit 3e510ec has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⌛ Testing commit 3e510ec with merge d6c4c74...
bors-servo added a commit that referenced this pull request May 24, 2018
@bors-servo
Auto merge of #20771 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d6c4c74 
Implement most of the unsupported parameters in gl.getParameter()

Fixes #20536.
Fixes #20537.
Fixes #20538.
Fixes #20544.
Fixes #20545.
Fixes #20546.
Fixes #20548.
Fixes #20549.
Fixes #20551.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20771)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing d6c4c74 to master...
@bors-servo bors-servo merged commit 3e510ec into master May 24, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the webgl branch May 24, 2018
@jdm jdm mentioned this pull request May 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @emilio @bors-servo @jdm
You can’t perform that action at this time.