Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "navigation within beforeunload" test to match the spec #20780

Merged
merged 1 commit into from May 20, 2018
Merged

update "navigation within beforeunload" test to match the spec #20780

merged 1 commit into from May 20, 2018
+6 −8

Conversation

@gterzian
Copy link
Member

gterzian commented May 13, 2018 •
edited by SimonSapin

Follow up on #20329 (comment)
@cbrewster

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@servo-wpt-sync servo-wpt-sync mentioned this pull request May 13, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 13, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#59.
@gterzian gterzian force-pushed the gterzian:fix_beforeunload_test branch from 43cc156 to 8f66a01 May 15, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 15, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#59.
@cbrewster cbrewster assigned cbrewster and unassigned pcwalton May 15, 2018
@cbrewster
Copy link
Member

cbrewster commented May 15, 2018

LGTM, you will need to run ./mach update-manifest since you changed a wpt test.
@gterzian gterzian force-pushed the gterzian:fix_beforeunload_test branch from 8f66a01 to b58429a May 16, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 16, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#59.
@cbrewster
Copy link
Member

cbrewster commented May 16, 2018

r=me once CI isn’t broken

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2018

✌️ @gterzian can now approve this pull request
@gterzian
Copy link
Member Author

gterzian commented May 16, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2018

📌 Commit b58429a has been approved by gterzian
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2018

⌛ Testing commit b58429a with merge 217ed77...
bors-servo added a commit that referenced this pull request May 16, 2018
@bors-servo
Auto merge of #20780 - gterzian:fix_beforeunload_test, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
217ed77 
update "navigation within beforeunload" test to match the spec

<!-- Please describe your changes on the following line: -->
 Follow up on #20329 (comment)
@cbrewster

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20780)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2018

💔 Test failed - android
@gterzian
Copy link
Member Author

gterzian commented May 16, 2018 •
edited

it seems both http://build.servo.org/builders/linux-rel-nogate and http://build.servo.org/builders/android are failing across builds at the moment...

related to #20788 and maybe #20774

as well as rustup[88446:17569580] Metadata.framework [Error]: couldn't get the client port in http://build.servo.org/builders/mac-rel-wpt4/builds/4298 and http://build.servo.org/builders/mac-rel-css2/builds/4294/
@gterzian
Copy link
Member Author

gterzian commented May 17, 2018

@bors-servo retry
@nox
Copy link
Member

nox commented May 17, 2018

@bors-servo treeclosed-
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

⌛ Testing commit b58429a with merge 660b8c0...
bors-servo added a commit that referenced this pull request May 17, 2018
@bors-servo
Auto merge of #20780 - gterzian:fix_beforeunload_test, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
660b8c0 
update "navigation within beforeunload" test to match the spec

<!-- Please describe your changes on the following line: -->
 Follow up on #20329 (comment)
@cbrewster

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20780)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member

jdm commented May 19, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

☔ The latest upstream changes (presumably #20824) made this pull request unmergeable. Please resolve the merge conflicts.
@gterzian
update "navigation within beforeunload" test to match the spec
Loading status checks…
9467543
@gterzian gterzian force-pushed the gterzian:fix_beforeunload_test branch from b58429a to 9467543 May 20, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 20, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#59.
@gterzian
Copy link
Member Author

gterzian commented May 20, 2018

rebased, this one will need a new r+...
@jdm
Copy link
Member

jdm commented May 20, 2018

@bors-servo r=cbrewster
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2018

📌 Commit 9467543 has been approved by cbrewster
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2018

⌛ Testing commit 9467543 with merge b9407ad...
bors-servo added a commit that referenced this pull request May 20, 2018
@bors-servo
Auto merge of #20780 - gterzian:fix_beforeunload_test, r=cbrewster
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b9407ad 
update "navigation within beforeunload" test to match the spec

<!-- Please describe your changes on the following line: -->
 Follow up on #20329 (comment)
@cbrewster

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20780)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2018

💔 Test failed - mac-rel-wpt2
@gterzian
Copy link
Member Author

gterzian commented May 20, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: cbrewster
Pushing b9407ad to master...
@bors-servo bors-servo merged commit 9467543 into servo:master May 20, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
jdm added a commit to web-platform-tests/wpt that referenced this pull request May 23, 2018
@gterzian @jdm
update "navigation within beforeunload" test to match the spec
cf5ab33 
Upstreamed from servo/servo#20780 [ci skip]
@servo-wpt-sync servo-wpt-sync mentioned this pull request May 23, 2018
Closed
jdm added a commit to web-platform-tests/wpt that referenced this pull request May 23, 2018
@gterzian @jdm
update "navigation within beforeunload" test to match the spec
40a0ace 
Upstreamed from servo/servo#20780 [ci skip]
@servo-wpt-sync servo-wpt-sync mentioned this pull request May 23, 2018
Merged
@gterzian gterzian deleted the gterzian:fix_beforeunload_test branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@gterzian @servo-wpt-sync @cbrewster @bors-servo @nox @jdm @pcwalton @highfive
You can’t perform that action at this time.