Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't suppress errors when executing mach bootstrap processes. #20782
Conversation
Omitting an argument to sys.exit causes it to default to 0, so buildbot doesn't report it as an error.
highfive
commented
May 14, 2018
|
Heads up! This PR modifies the following files:
|
|
cc @glennw |
|
Of course, we won't be able to merge this change until #20774 is fixed... |
|
Oops! r=me when the tree is open. |
|
@bors-servo p=1000 r=glennw treeclosed- |
|
|
Don't suppress errors when executing mach bootstrap processes. [Omitting an argument](https://docs.python.org/2/library/sys.html#sys.exit) to sys.exit causes it to default to 0, so buildbot doesn't report it as an error. We were just lucky that the android builders happened to have a build step that failed that didn't rely on running python! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20782) <!-- Reviewable:end -->
|
|
|
Huh, this seems to expose an issue on appveyor: This appears on the windows builder as well. |
|
@bors-servo try treeclosed- |
Don't suppress errors when executing mach bootstrap processes. [Omitting an argument](https://docs.python.org/2/library/sys.html#sys.exit) to sys.exit causes it to default to 0, so buildbot doesn't report it as an error. We were just lucky that the android builders happened to have a build step that failed that didn't rely on running python! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20782) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@bors-servo r=glennw |
|
|
|
|
|
|
|
@bors-servo try- retry |
Don't suppress errors when executing mach bootstrap processes. [Omitting an argument](https://docs.python.org/2/library/sys.html#sys.exit) to sys.exit causes it to default to 0, so buildbot doesn't report it as an error. We were just lucky that the android builders happened to have a build step that failed that didn't rely on running python! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20782) <!-- Reviewable:end -->
|
|
|
@bors-servo p=9000 |
|
@bors-servo retry |
|
@bors-servo treeclosed- |
Don't suppress errors when executing mach bootstrap processes. [Omitting an argument](https://docs.python.org/2/library/sys.html#sys.exit) to sys.exit causes it to default to 0, so buildbot doesn't report it as an error. We were just lucky that the android builders happened to have a build step that failed that didn't rely on running python! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20782) <!-- Reviewable:end -->
|
@bors-servo treeclosed=9000 |
|
|
jdm commentedMay 14, 2018
•
edited by SimonSapin
Omitting an argument to sys.exit causes it to default to 0, so buildbot doesn't report it as an error.
We were just lucky that the android builders happened to have a build step that failed that didn't rely on running python!
This change is