Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #20786

Merged
merged 11 commits into from May 19, 2018
Merged

style: Sync changes from mozilla-central. #20786

merged 11 commits into from May 19, 2018

Conversation

@emilio
Copy link
Member

emilio commented May 15, 2018 •
edited by SimonSapin

See individual commits for details.

This change is Reviewable
@highfive
Copy link

highfive commented May 15, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/pointing.rs, components/style/properties/longhand/background.mako.rs, components/style/values/specified/resolution.rs, components/style/properties/gecko.mako.rs, components/style/values/computed/mod.rs and 27 more
  • @canaltinova: components/style/values/specified/pointing.rs, components/style/properties/longhand/background.mako.rs, components/style/values/specified/resolution.rs, components/style/properties/gecko.mako.rs, components/style/values/computed/mod.rs and 27 more
@highfive
Copy link

highfive commented May 15, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented May 15, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2018

📌 Commit f1354de has been approved by emilio
@highfive highfive assigned emilio and unassigned jdm May 15, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2018

⌛ Testing commit f1354de with merge 0c699ab...
bors-servo added a commit that referenced this pull request May 15, 2018
@bors-servo
Auto merge of #20786 - emilio:gecko-sync, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c699ab 
style: Sync changes from mozilla-central.

See individual commits for details.
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2018

💔 Test failed - android
@emilio
Copy link
Member Author

emilio commented May 15, 2018

@bors-servo retry

  • Not sure this is expected or not, worth a retry I guess
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2018

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android, mac-rel-css1, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented May 15, 2018

@bors-servo treeclosed=9000
Tree is still closed.
@emilio
Copy link
Member Author

emilio commented May 18, 2018 •
edited

@bors-servo retry

  • Looks like stuff is landing now :)
@emilio
Copy link
Member Author

emilio commented May 18, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #20718
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

📌 Commit f1354de has been approved by emilio
@emilio emilio closed this May 19, 2018
@emilio emilio reopened this May 19, 2018
@emilio
Copy link
Member Author

emilio commented May 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #20506
krispyfries and others added 8 commits May 8, 2018
@krispyfries @emilio
style: Convert NS_STYLE_IMAGELAYER_ATTACHMENT_* to enum class.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
2688588 
Converted NS_STYLE_IMAGELAYER_ATTATCHMENT_* vals to enum class, StyleImageLayerAttachment.

Bug: 1459367
Reviewed-by: Manishearth
@emilio
style: Make resolutions more like the rest of the CSS values.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
2f18b67 
Bug: 1460655
Reviewed-by: xidorn
MozReview-Commit-ID: 3Gt8VX1KhjC
@emilio
style: Support x as a resolution unit.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
ce62cb1 
Bug: 1460655
Reviewed-by: xidorn
MozReview-Commit-ID: TjU0FLCLMN
@emilio
style: Ensure all lonhands have a working clone(), and to_css.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
a6328ba 
This removes some dubious font-family code too.

It ensures that vector longhands have a proper clone implementation
auto-generating it using `collect()`.

Bug: 1461296
Reviewed-by: xidorn
MozReview-Commit-ID: FkdnbTkeF6E
@emilio
style: Distinguish between specified and computed URLs.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
1314f47 
This is needed to serialize computed URLs correctly from getComputedStyle.

Bug: 1461288
Reviewed-by: xidorn
MozReview-Commit-ID: 9wakhqNrszb
@emilio
style: Don't crash when finding an unexpected default font type.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
dccb826 
For now just return sans-serif, though as the FIXME comment indicates we should
probably just carry around the font-name instead.

Bug: 1442195
Reviewed-by: xidorn
MozReview-Commit-ID: CIPbV3R5Ul
@emilio
Make servo-tidy happy.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
164bfbc
@emilio
Fix Servo build.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
2a50079
@emilio emilio force-pushed the emilio:gecko-sync branch from f1354de to 2a50079 May 19, 2018
@emilio
Copy link
Member Author

emilio commented May 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

📌 Commit 2a50079 has been approved by emilio
@emilio
Copy link
Member Author

emilio commented May 19, 2018

@bors-servo p=1

  • Kinda shameless, sorry, but I have more commits on the queue :)
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

⌛ Testing commit 2a50079 with merge c336b75...
bors-servo added a commit that referenced this pull request May 19, 2018
@bors-servo
Auto merge of #20786 - emilio:gecko-sync, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c336b75 
style: Sync changes from mozilla-central.

See individual commits for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20786)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

💔 Test failed - mac-rel-css2
@emilio
Copy link
Member Author

emilio commented May 19, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

⌛ Testing commit 2a50079 with merge b536774...
bors-servo added a commit that referenced this pull request May 19, 2018
@bors-servo
Auto merge of #20786 - emilio:gecko-sync, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b536774 
style: Sync changes from mozilla-central.

See individual commits for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20786)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing b536774 to master...
@bors-servo bors-servo merged commit 2a50079 into servo:master May 19, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:gecko-sync branch May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @jdm @upsuper @krispyfries
You can’t perform that action at this time.