Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet the mozjs crate to work with the mozjs_sys which uses bindgen #20793
Conversation
highfive
commented
May 16, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 16, 2018
|
|
|
r? @jdm |
|
(The commits should be cleaned up before landing the PR.) |
asajeffrey
changed the title
|
@jdm: the bindgenup landed in mozjs, so this is now ready for review. |
|
Squashed. @bors-servo r=jdm |
|
|
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
|
|
|
All of the linux, arm, and android builders complained: |
|
And windows: |
|
Also http://build.servo.org/builders/linux-rel-css/builds/8802 complained: All these errors make me suspicious about the libclang on our build machines. |
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
|
|
|
@bors-servo retry |
|
|
|
@bors-servo retry
|
|
|
|
|
Get the mozjs crate to work with the mozjs_sys which uses bindgen <!-- Please describe your changes on the following line: --> This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because current tests should catch failures <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20793) <!-- Reviewable:end -->
|
|
|
Since the mozjs v0.7.1 update, I can't compile anymore: #20958 |
asajeffrey commentedMay 16, 2018
•
edited by SimonSapin
This is the matching PR to servo/mozjs#134 and servo/rust-mozjs#425 which runs bindgen on spidermonkey to produce Rust bindings.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is