Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (16-05-2018) #20794

Closed

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 17, 2018

Automated downstream sync of changes from upstream as of 16-05-2018.
[no-wpt-sync]


This change is Reviewable

Copy link
Member

nox left a comment

@jdm Did a review of all the expectation changes, tell me what you think.

@@ -1,8 +1,11 @@
[url-in-tags-revoke.window.html]
expected: TIMEOUT

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

That's a new timeout, and reverting the changes made to the test in that PR doesn't make it go away.

[Blob URL fragment is implemented.]
expected: FAIL
expected: TIMEOUT

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

This one is due to https://github.com/servo/servo/pull/20794/files#diff-f3bbe86981f8b2d223aa16ad8a140d13R45 where iframe.onload is changed to iframe.contentWindow.onscroll.

@@ -0,0 +1,4 @@
[Node-normalize.html]
[Non-text nodes with empty textContent values.]

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

Legit failure, we don't implement document.createCDATASection.

@@ -0,0 +1,9 @@
[response-stream-with-broken-then.any.html]

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member
invalid arrow-function arguments (parentheses around the arrow-function may help)
@@ -0,0 +1,2 @@
[basic-auth-cache-test.html]
expected: TIMEOUT

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

Legit, new test.

@@ -0,0 +1,8 @@
[navigate.window.html]
expected: TIMEOUT

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

Both new tests.

@@ -0,0 +1,4 @@
[generic.keep-origin-redirect.http.html]
[The referrer URL is origin when a\n document served over http requires an http\n sub-resource via script-tag using the attr-referrer\n delivery method with keep-origin-redirect and when\n the target request is cross-origin.]

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

AFAICT this and all similar failures are new tests.

@@ -0,0 +1,16 @@
[historical.html]

This comment has been minimized.

Copy link
@nox

nox May 17, 2018

Member

Legit failures, document.createTouch disappeared in favour of a Touch constructor.

@jdm
Copy link
Member

jdm commented May 17, 2018

@bors-servo treeclosed-

@jdm jdm changed the title [WIP] Sync WPT with upstream (16-05-2018) Sync WPT with upstream (16-05-2018) May 18, 2018
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

📌 Commit f1a7f77 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

Testing commit f1a7f77 with merge a8f0fb4...

bors-servo added a commit that referenced this pull request May 18, 2018
Sync WPT with upstream (16-05-2018)

Automated downstream sync of changes from upstream as of 16-05-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20794)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented May 18, 2018

@jdm
Copy link
Member

jdm commented May 19, 2018

Closing in favour of #20824.

@jdm jdm closed this May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.