Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable codegen-units on macOS #20795

Closed
wants to merge 1 commit into from
Closed

Disable codegen-units on macOS #20795

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented May 17, 2018 •
edited by SimonSapin

If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug.

This change is Reviewable
@jdm
Disable codegen-units on macOS
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f651af
@highfive
Copy link

highfive commented May 17, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented May 17, 2018

r? @mbrubeck
@highfive highfive assigned mbrubeck and unassigned glennw May 17, 2018
@mbrubeck
Copy link
Contributor

mbrubeck commented May 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

📌 Commit 3f651af has been approved by mbrubeck
@jdm
Copy link
Member Author

jdm commented May 17, 2018

@bors-servo p=1000
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

⌛ Testing commit 3f651af with merge de25bae...
bors-servo added a commit that referenced this pull request May 17, 2018
@bors-servo
Auto merge of #20795 - servo:jdm-patch-16, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
de25bae 
Disable codegen-units on macOS

If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

💔 Test failed - mac-rel-wpt4
@mbrubeck
Copy link
Contributor

mbrubeck commented May 17, 2018

@bors-servo retry

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html:
  │ FAIL [expected PASS] Salvagability of document.opened document
  │   → assert_unreached: Reached unreachable code
  │ 
  │ onload</<@http://web-platform.test:8000/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html:20:38
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1490:20
  └ Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1514:20

  ▶ TIMEOUT [expected ERROR] /html/dom/dynamic-markup-insertion/opening-the-input-stream/009.https.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 17.3.0-devel
  │ ERROR 2018-05-17T21:02:46Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(2, PipelineId(0, 1)), pipeline_id: PipelineId(1, 2) }
  │ ERROR 2018-05-17T21:02:46Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(2, PipelineId(0, 1)), pipeline_id: PipelineId(1, 2) }
  │ ERROR 2018-05-17T21:02:46Z: script::dom::bindings::error: Error at https://web-platform.test:8443/html/dom/dynamic-markup-insertion/opening-the-input-stream/009.https.html:15:3 handle is undefined
  └ ERROR 2018-05-17T21:02:46Z: script::dom::bindings::error: Error at https://web-platform.test:8443/html/dom/dynamic-markup-insertion/opening-the-input-stream/009.https.html:32:3 steps is undefined
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

⌛ Testing commit 3f651af with merge 2c7674f...
bors-servo added a commit that referenced this pull request May 17, 2018
@bors-servo
Auto merge of #20795 - servo:jdm-patch-16, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c7674f 
Disable codegen-units on macOS

If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

💔 Test failed - linux-rel-css
@KiChjang
Copy link
Member

KiChjang commented May 17, 2018 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

⌛ Testing commit 3f651af with merge ace3cc8...
bors-servo added a commit that referenced this pull request May 17, 2018
@bors-servo
Auto merge of #20795 - servo:jdm-patch-16, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ace3cc8 
Disable codegen-units on macOS

If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

💔 Test failed - mac-dev-unit
@mbrubeck
Copy link
Contributor

mbrubeck commented May 17, 2018

Oh well.
@mbrubeck mbrubeck closed this May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @mbrubeck @bors-servo @KiChjang @glennw
You can’t perform that action at this time.