Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase taskcluster runtime #20841

Merged
merged 2 commits into from May 25, 2018
Merged

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented May 21, 2018

Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.

Also, add set -x for easier debugging.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they are trying to fix the testing infra

This change is Reviewable

aneeshusa added 2 commits May 21, 2018
Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.
Print out each command before it is run,
to help debug future Taskcluster issues.
@aneeshusa
Copy link
Member Author

aneeshusa commented May 21, 2018

r? @edunham
With #20790, the Taskcluster jobs now seem to be mostly working, so try to get them fully working again.

@highfive highfive assigned edunham and unassigned mbrubeck May 21, 2018
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo r+ force

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

📌 Commit 6861f9b has been approved by jdm

@highfive highfive assigned jdm and unassigned edunham May 24, 2018
bors-servo added a commit that referenced this pull request May 24, 2018
Increase taskcluster runtime

<!-- Please describe your changes on the following line: -->

Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.

Also, add `set -x` for easier debugging.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are trying to fix the testing infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

Testing commit 6861f9b with merge f094cd2...

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

Testing commit 6861f9b with merge dc7a1df...

bors-servo added a commit that referenced this pull request May 24, 2018
Increase taskcluster runtime

<!-- Please describe your changes on the following line: -->

Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.

Also, add `set -x` for easier debugging.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are trying to fix the testing infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

Testing commit 6861f9b with merge e67bf2d...

bors-servo added a commit that referenced this pull request May 24, 2018
Increase taskcluster runtime

<!-- Please describe your changes on the following line: -->

Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.

Also, add `set -x` for easier debugging.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are trying to fix the testing infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-dev-unit

@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry

  • backing out the cssparser upgrade
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

Testing commit 6861f9b with merge f63284e...

bors-servo added a commit that referenced this pull request May 25, 2018
Increase taskcluster runtime

<!-- Please describe your changes on the following line: -->

Based on the Taskcluster log for
(https://taskcluster-artifacts.net/HkxDh1oKQceXH1fL9RSGow/0/public/logs/live_backing.log),
it looks like the job is running successfully but hitting the max time limit.

Our builds + tests shouldn't take this long to run normally,
but we'll need to set up sccache with cache uploading/downloading
in order to improve most build times.

For now, bump the max run time to 2 hours;
since we complete one build + som tests within an hour,
2 hours should be enough for the second build to finish as well.

Also, add `set -x` for easier debugging.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are trying to fix the testing infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

@bors-servo bors-servo merged commit 6861f9b into servo:master May 25, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.