Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sync WPT with upstream (20-05-2018) #20842

Closed

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 21, 2018

⚠️ Do not merge this PR without verifying that it is not overwriting local changes to web-platform-tests. ⚠️

Automated downstream sync of changes from upstream as of 20-05-2018.
[no-wpt-sync]


This change is Reviewable

@@ -0,0 +1,4 @@
[navigation-within-beforeunload.html]

This comment has been minimized.

@nox

nox May 21, 2018

Member

New failure, test hasn't been changed since 2015.

This comment has been minimized.

@nox

nox May 21, 2018

Member

Never mind, it had recent changes, I just didn't look at the right place.

This comment has been minimized.

@nox

nox May 21, 2018

Member

Never mind bis, the issue here is that 9467543 didn't get upstreamed correctly. Cc @jdm

@@ -1,4 +1,5 @@
[javascript-url-abort-return-value-undefined.tentative.html]
expected: TIMEOUT

This comment has been minimized.

@@ -0,0 +1,17 @@
[Close-1000-reason.any.html]

This comment has been minimized.

@nox

nox May 21, 2018

Member

That's the weird thing where none of the WebSockets tests pass, I'll revert those. Is upstream even aware of this problem? Is it something that we ourselves broke somehow in our setup?

This comment has been minimized.

@jdm

jdm May 21, 2018

Member

I have not seen anybody else complaining about this.

This comment has been minimized.

@nox

nox May 21, 2018

Member

Did we document the failure somewhere? Looking for the output and maybe stacktraces and whatnot.

This comment has been minimized.

@jdm

jdm May 21, 2018

Member

#20734. web-platform-tests/wpt#10804 was reverted before we got a chance to observe any output changes because it broke gecko's setup.

@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

The latest upstream changes (presumably #20851) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm jdm closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.