Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix font-stretch animation. #20843

Merged
merged 1 commit into from May 21, 2018
Merged

style: Fix font-stretch animation. #20843

merged 1 commit into from May 21, 2018

Conversation

@emilio
Copy link
Member

emilio commented May 21, 2018 •
edited by SimonSapin

This is a regression from #20506 which Gecko tests caught while trying to import
this.

This change is Reviewable
@emilio
style: Fix font-stretch animation.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
b6a1742 
This is a regression from #20506 which Gecko tests caught while trying to import
this.
@highfive
Copy link

highfive commented May 21, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/computed/font.rs
  • @canaltinova: components/style/values/computed/font.rs
@highfive
Copy link

highfive commented May 21, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented May 21, 2018

@bors-servo r+

  • It's trivial.
@bors-servo
Copy link
Contributor

bors-servo commented May 21, 2018

📌 Commit b6a1742 has been approved by emilio
@highfive highfive assigned emilio and unassigned glennw May 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 21, 2018

⌛ Testing commit b6a1742 with merge 319556c...
bors-servo added a commit that referenced this pull request May 21, 2018
@bors-servo
Auto merge of #20843 - emilio:font-stretch-anim, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
319556c 
style: Fix font-stretch animation.

This is a regression from #20506 which Gecko tests caught while trying to import
this.
@emilio
Copy link
Member Author

emilio commented May 21, 2018

cc @jonleighton, sorry I overlooked this while reviewing #20506 :/
@bors-servo
Copy link
Contributor

bors-servo commented May 21, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 319556c to master...
@bors-servo bors-servo merged commit b6a1742 into servo:master May 21, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jonleighton
Copy link
Contributor

jonleighton commented May 21, 2018

Sorry, thanks for fixing it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @jonleighton @glennw
You can’t perform that action at this time.