Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix font-stretch animation. #20843

Merged
merged 1 commit into from
May 21, 2018
Merged

Conversation

emilio
Copy link
Member

@emilio emilio commented May 21, 2018

This is a regression from #20506 which Gecko tests caught while trying to import
this.


This change is Reviewable

This is a regression from servo#20506 which Gecko tests caught while trying to import
this.
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/computed/font.rs
  • @canaltinova: components/style/values/computed/font.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 21, 2018
@emilio
Copy link
Member Author

emilio commented May 21, 2018

@bors-servo r+

  • It's trivial.

@bors-servo
Copy link
Contributor

📌 Commit b6a1742 has been approved by emilio

@highfive highfive assigned emilio and unassigned glennw May 21, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 21, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit b6a1742 with merge 319556c...

bors-servo pushed a commit that referenced this pull request May 21, 2018
style: Fix font-stretch animation.

This is a regression from #20506 which Gecko tests caught while trying to import
this.
@emilio
Copy link
Member Author

emilio commented May 21, 2018

cc @jonleighton, sorry I overlooked this while reviewing #20506 :/

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 319556c to master...

@bors-servo bors-servo merged commit b6a1742 into servo:master May 21, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 21, 2018
@jonleighton
Copy link
Contributor

Sorry, thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants