Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate websocket timeouts #20850

Closed
wants to merge 13 commits into from
Closed

Investigate websocket timeouts #20850

wants to merge 13 commits into from

Conversation

@jdm
Copy link
Member

jdm commented May 22, 2018 •
edited by mbrubeck

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

This change is Reviewable
jdm added 2 commits May 22, 2018
@jdm
Disable nightly WPT sync.
b86307c
@jdm
Make websocket server use WPT logging.
Loading status checks…
6ada395
@highfive
Copy link

highfive commented May 22, 2018

Heads up! This PR modifies the following files:
@servo-wpt-sync servo-wpt-sync mentioned this pull request May 22, 2018
Closed
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 22, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#61.
@jdm
Copy link
Member Author

jdm commented May 22, 2018

@bors-servo r+
jgraham wrote the logging changes, so I'm going to go ahead and merge them to start getting information from failed test runs as soon as possible.
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2018

📌 Commit 6ada395 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio May 22, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2018

⌛ Testing commit 6ada395 with merge 60501f1...
bors-servo added a commit that referenced this pull request May 22, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60501f1 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2018

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt2, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt2, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

💔 Test failed - mac-rel-wpt2
@jdm jdm closed this May 23, 2018
@jdm jdm reopened this May 31, 2018
@jdm
Copy link
Member Author

jdm commented May 31, 2018

@bors-servo try
@servo-wpt-sync servo-wpt-sync mentioned this pull request May 31, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2018

⌛ Trying commit e646931 with merge 9d5c6f8...
bors-servo added a commit that referenced this pull request Jun 8, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d5c6f8 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
reduce debug output
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
727e11a
@jdm
Copy link
Member Author

jdm commented Jun 8, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2018

⌛ Trying commit 727e11a with merge 16900e9...
bors-servo added a commit that referenced this pull request Jun 8, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
16900e9 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 8, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#64.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2018

💔 Test failed - linux-rel-wpt
@jdm
More pywebsocket logging
Loading status checks…
4892350
@jdm
Copy link
Member Author

jdm commented Jun 15, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

⌛ Trying commit 4892350 with merge d311ca1...
bors-servo added a commit that referenced this pull request Jun 15, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d311ca1 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 15, 2018

Error syncing changes upstream. Logs saved in error-snapshot-1529082972344.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Jun 15, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

⌛ Trying commit 4892350 with merge 0e76210...
bors-servo added a commit that referenced this pull request Jun 15, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0e76210 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
Reduce debug outupt
Loading status checks…
4072add
@jdm
Copy link
Member Author

jdm commented Jun 15, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

⌛ Trying commit 4072add with merge ef138db...
bors-servo added a commit that referenced this pull request Jun 15, 2018
@bors-servo
Auto merge of #20850 - jdm:websocket-investigate, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ef138db 
Investigate websocket timeouts

This is designed to extract more information to diagnose #20734. It disables the nightly sync job so that the logging changes don't get reverted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20850)
<!-- Reviewable:end -->
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 15, 2018

Error syncing changes upstream. Logs saved in error-snapshot-1529088643715.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 15, 2018

💔 Test failed - mac-rel-css2
@jdm jdm removed the S-awaiting-review label Jun 19, 2018
@jdm jdm closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @servo-wpt-sync @bors-servo @emilio
You can’t perform that action at this time.