Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive-by fixes in WebGL #20854

Merged
merged 2 commits into from May 25, 2018
Merged

Drive-by fixes in WebGL #20854

merged 2 commits into from May 25, 2018

Conversation

@nox
Copy link
Member

nox commented May 24, 2018 •
edited by SimonSapin

This change is Reviewable
nox added 2 commits May 22, 2018
@nox
Add OESElementIndexUint to WebGLExtensions::register_all_extensions
54f88b5
@nox
Move WebGLVertexArrayObjectOES to script::dom
Loading status checks…
b523267 
It's not a WebGL extension itself, it's just used by one.
@highfive
Copy link

highfive commented May 24, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/mod.rs, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs
  • @fitzgen: components/script/dom/mod.rs, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs
  • @KiChjang: components/script/dom/mod.rs, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs
@highfive
Copy link

highfive commented May 24, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Sign in to view
Copy link
Member Author

nox commented on b523267 May 24, 2018 •
edited

@jdm Why is @taskcluster bothering us on commits now?

This comment has been minimized.

Sign in to view
Copy link
Member

jdm replied May 24, 2018

@edunham has been playing with it again.
@emilio
emilio approved these changes May 24, 2018
View changes
@emilio
Copy link
Member

emilio commented May 24, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

📌 Commit b523267 has been approved by emilio
@highfive highfive assigned emilio and unassigned mbrubeck May 24, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⌛ Testing commit b523267 with merge f33bc5f...
bors-servo added a commit that referenced this pull request May 24, 2018
@bors-servo
Auto merge of #20854 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f33bc5f 
Drive-by fixes in WebGL

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

⌛ Testing commit b523267 with merge f14617c...
bors-servo added a commit that referenced this pull request May 24, 2018
@bors-servo
Auto merge of #20854 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f14617c 
Drive-by fixes in WebGL

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented May 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

⌛ Testing commit b523267 with merge 31f91ec...
bors-servo added a commit that referenced this pull request May 25, 2018
@bors-servo
Auto merge of #20854 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31f91ec 
Drive-by fixes in WebGL

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 31f91ec to master...
@bors-servo bors-servo merged commit b523267 into master May 25, 2018
4 of 5 checks passed
4 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @emilio @bors-servo @jdm @mbrubeck
You can’t perform that action at this time.