Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmove test `dom-element-scroll.html` from mozilla to wpt #20858
Merged
Conversation
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#62. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 24, 2018
move test `dom-element-scroll.html` from mozilla to wpt <!-- Please describe your changes on the following line: --> The test `dom-element-scroll.html` was originally landed on #19127. It was designed for testing `scrollLeft` and `scrollTop`. It is not only for servo. I thought I put a wrong place at that time. It should not be under `mozilla`. It's better placed under `wpt`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20858) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 24, 2018
move test `dom-element-scroll.html` from mozilla to wpt <!-- Please describe your changes on the following line: --> The test `dom-element-scroll.html` was originally landed on #19127. It was designed for testing `scrollLeft` and `scrollTop`. It is not only for servo. I thought I put a wrong place at that time. It should not be under `mozilla`. It's better placed under `wpt`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20858) <!-- Reviewable:end -->
|
|
|
|
That's just servo-mac1 acting up. More important is this error: |
|
I forgot to update manifest. Sorry for this. |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#62. |
|
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#62. |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#62. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 25, 2018
move test `dom-element-scroll.html` from mozilla to wpt <!-- Please describe your changes on the following line: --> The test `dom-element-scroll.html` was originally landed on #19127. It was designed for testing `scrollLeft` and `scrollTop`. It is not only for servo. I thought I put a wrong place at that time. It should not be under `mozilla`. It's better placed under `wpt`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20858) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 7, 2018
Upstreamed from servo/servo#20858 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tigercosmos commentedMay 24, 2018
•
edited by SimonSapin
The test
dom-element-scroll.htmlwas originally landed on #19127.It was designed for testing
scrollLeftandscrollTop.It is not only for servo. I thought I put a wrong place at that time. It should not be under
mozilla. It's better placed underwpt.This change is