Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less judgemental when tearing down WebGL rendering contexts #20877

Merged
merged 1 commit into from May 29, 2018
Merged

Be less judgemental when tearing down WebGL rendering contexts #20877

merged 1 commit into from May 29, 2018
+1 −1

Conversation

@jdm
Copy link
Member

jdm commented May 29, 2018 •
edited by SimonSapin

r? nox

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it relies on the webgl thread behaving badly.

This change is Reviewable
@jdm
Don't panic when tearing down a WebGL context and the thead is unreac…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b1202cf 
…hable.

This avoids some cascading double-panics when there are errors in the WebGL rendering thread.
@highfive
Copy link

highfive commented May 29, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @fitzgen: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented May 29, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented May 29, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

📌 Commit b1202cf has been approved by emilio
@highfive highfive assigned emilio and unassigned nox May 29, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

⌛ Testing commit b1202cf with merge 11a89bc...
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #20877 - servo:jdm-patch-6, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
11a89bc 
Be less judgemental when tearing down WebGL rendering contexts

r? nox

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it relies on the webgl thread behaving badly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20877)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

💔 Test failed - mac-rel-css2
@jdm
Copy link
Member Author

jdm commented May 29, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2...
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 11a89bc to master...
@bors-servo bors-servo merged commit b1202cf into master May 29, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-6 branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @emilio @bors-servo @nox
You can’t perform that action at this time.