Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging output for WebGL errors. #20878

Merged
merged 1 commit into from May 31, 2018
Merged

Improve debugging output for WebGL errors. #20878

merged 1 commit into from May 31, 2018
+115 −246

Conversation

@jdm
Copy link
Member

jdm commented May 29, 2018 •
edited by SimonSapin

This changes made it much easier to figure out what was triggering #20876.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they only affect error output.

This change is Reviewable
@jdm
Copy link
Member Author

jdm commented May 29, 2018

r? @avadacatavra
@highfive highfive assigned avadacatavra and unassigned nox May 29, 2018
@jdm jdm mentioned this pull request May 29, 2018
Closed
@jdm
Improve debugging output for WebGL errors.
Loading status checks…
41ced88
@jdm jdm force-pushed the jdm:paramdebug branch from fbf3fc4 to 41ced88 May 29, 2018
@avadacatavra
Copy link
Contributor

avadacatavra commented May 31, 2018

The macro looks so much better than the giant match :)

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

📌 Commit 41ced88 has been approved by avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

⌛ Testing commit 41ced88 with merge 35cd2e9...
bors-servo added a commit that referenced this pull request May 31, 2018
@bors-servo
Auto merge of #20878 - jdm:paramdebug, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
35cd2e9 
Improve debugging output for WebGL errors.

This changes made it much easier to figure out what was triggering #20876.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only affect error output.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20878)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

💔 Test failed - mac-rel-css2
@jdm
Copy link
Member Author

jdm commented May 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-css2...
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: avadacatavra
Pushing 35cd2e9 to master...
@bors-servo bors-servo merged commit 41ced88 into servo:master May 31, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @avadacatavra @bors-servo @nox @highfive
You can’t perform that action at this time.