Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forward GL parameter gets for constant limits. #20884

Merged
merged 1 commit into from May 31, 2018
Merged

Don't forward GL parameter gets for constant limits. #20884

merged 1 commit into from May 31, 2018

Conversation

@jdm
Copy link
Member

jdm commented May 30, 2018 •
edited by SimonSapin

This avoids IPC traffic for unchanging constants that are determined when the GL context is created. These changes require servo/surfman#123.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20876.
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented May 30, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @fitzgen: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented May 30, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented May 30, 2018

r? @avadacatavra
@highfive highfive assigned avadacatavra and unassigned Manishearth May 30, 2018
@avadacatavra
Copy link
Contributor

avadacatavra commented May 31, 2018

Looks good!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

📌 Commit 4f742b5 has been approved by avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

⌛ Testing commit 4f742b5 with merge ee597a7...
bors-servo added a commit that referenced this pull request May 31, 2018
@bors-servo
Auto merge of #20884 - jdm:more-limits, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee597a7 
Don't forward GL parameter gets for constant limits.

This avoids IPC traffic for unchanging constants that are determined when the GL context is created. These changes require servo/surfman#123.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20876.
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20884)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

💔 Test failed - android
@jdm
Don't forward GL parameter gets for constant limits.
Loading status checks…
76c29f8
@jdm jdm force-pushed the jdm:more-limits branch from 4f742b5 to 76c29f8 May 31, 2018
@jdm
Copy link
Member Author

jdm commented May 31, 2018

@bors-servo r=avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

📌 Commit 76c29f8 has been approved by avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

⌛ Testing commit 76c29f8 with merge 022dacc...
bors-servo added a commit that referenced this pull request May 31, 2018
@bors-servo
Auto merge of #20884 - jdm:more-limits, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
022dacc 
Don't forward GL parameter gets for constant limits.

This avoids IPC traffic for unchanging constants that are determined when the GL context is created. These changes require servo/surfman#123.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20876.
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20884)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member Author

jdm commented May 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: avadacatavra
Pushing 022dacc to master...
@bors-servo bors-servo merged commit 76c29f8 into servo:master May 31, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Many A-Frame examples fail when getting the GL_MAX_VERTEX_UNIFORM_COMPONENTS parameter
5 participants
@jdm @highfive @avadacatavra @bors-servo @Manishearth
You can’t perform that action at this time.