Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBasic framework for running web platform tests #2089
Conversation
hoppipolla-critic-bot
commented
Apr 10, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1219 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Some tests seem to be partially passing now. Note that the manifest generation requires the working dir to be clean (I think the working dir of resources/) |
See #1479 This sets up a basic environment for running wpt. It instantiates a virtualenv, generates the manifest if it doesn't exist*, and runs the tests. Currently @Ms2ger's [`run-in-servo` fork of wpt](https://github.com/Ms2ger/web-platform-tests/tree/run-in-servo/) is used. Note: I did everything in a shell script instead of make since one cannot run `source` from a makefile (the environment is immutable, apparently) *It does not, however, update the manifest. We'll have to add an extra script for that.
See #1479 This sets up a basic environment for running wpt. It instantiates a virtualenv, generates the manifest if it doesn't exist*, and runs the tests. Currently @Ms2ger's [`run-in-servo` fork of wpt](https://github.com/Ms2ger/web-platform-tests/tree/run-in-servo/) is used. Note: I did everything in a shell script instead of make since one cannot run `source` from a makefile (the environment is immutable, apparently) *It does not, however, update the manifest. We'll have to add an extra script for that.
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on 8cdaa9a
Apr 18, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging Manishearth/servo/wpt = 8cdaa9a into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 9edfb43 |
See #1479 This sets up a basic environment for running wpt. It instantiates a virtualenv, generates the manifest if it doesn't exist*, and runs the tests. Currently @Ms2ger's [`run-in-servo` fork of wpt](https://github.com/Ms2ger/web-platform-tests/tree/run-in-servo/) is used. Note: I did everything in a shell script instead of make since one cannot run `source` from a makefile (the environment is immutable, apparently) *It does not, however, update the manifest. We'll have to add an extra script for that.
bors-servo
merged commit 8cdaa9a
into
servo:master
Manishearth commentedApr 10, 2014
See #1479
This sets up a basic environment for running wpt. It instantiates a virtualenv, generates the manifest if it doesn't exist*, and runs the tests.
Currently @Ms2ger's
run-in-servofork of wpt is used.Note: I did everything in a shell script instead of make since one cannot run
sourcefrom a makefile (the environment is immutable, apparently)*It does not, however, update the manifest. We'll have to add an extra script for that.