Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(servo): bump up llvm to 6.0.0 #20895

Merged
merged 1 commit into from Jun 1, 2018
Merged

build(servo): bump up llvm to 6.0.0 #20895

merged 1 commit into from Jun 1, 2018

Conversation

@kwonoj
Copy link
Contributor

kwonoj commented Jun 1, 2018

This PR bumps up llvm to 6.0.0 to allow vs2017 build works on windows.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20888 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented Jun 1, 2018

Heads up! This PR modifies the following files:

@asajeffrey
Copy link
Member

asajeffrey commented Jun 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

📌 Commit f18f393 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

Testing commit f18f393 with merge 0c703fb...

bors-servo added a commit that referenced this pull request Jun 1, 2018
build(servo): bump up llvm to 6.0.0

<!-- Please describe your changes on the following line: -->
This PR bumps up llvm to 6.0.0 to allow vs2017 build works on windows.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #20888 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20895)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

💔 Test failed - mac-rel-css2

@asajeffrey
Copy link
Member

asajeffrey commented Jun 1, 2018

Ah, servo-mac-3 we meet again.

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

💔 Test failed - mac-rel-wpt2

@asajeffrey
Copy link
Member

asajeffrey commented Jun 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

@asajeffrey
Copy link
Member

asajeffrey commented Jun 1, 2018

In particular, the MSVC builds on both appveyor and buildbot succeeded.

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

💔 Test failed - mac-rel-wpt2

@asajeffrey
Copy link
Member

asajeffrey commented Jun 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2018

@bors-servo bors-servo merged commit f18f393 into servo:master Jun 1, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kwonoj kwonoj deleted the kwonoj:bump-dep branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.