Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: sync changes from mozilla-central. #20900
Merged
+456
−351
Conversation
Bug: 1463599 Reviewed-by: mattwoodrow MozReview-Commit-ID: Ln72MOlHXwi
Corresponding to this spec change; w3c/csswg-drafts@3281266 The expected value in test_transitions_per_property.html can be calculated; 'start' + ('end' - 'start') * 0.25 Bug: 1464647 Reviewed-by: birtles, emilio MozReview-Commit-ID: NI9gOUuPnG
MozReview-Commit-ID: 5CdOdQPZzyb
…fect the namespace map. Bug: 1464865 Reviewed-by: xidorn MozReview-Commit-ID: 9bjlEBExqsr
Bug: 1464865 Reviewed-by: xidorn MozReview-Commit-ID: 8ClaBR9ooGb
Reviewed-by: hiro But: 1465066 MozReview-Commit-ID: D9rq8CZIgf5
… other NAC inherit from their parents.
Currently, NAC always inherits from the closest non-NAC ancestor element,
regardless of whether it is for an element-backed pseudo or not.
This patch changes the inheritance so that for element-backed pseudos, we
inherit from the closest native anonymous root's parent, and for other NAC we
inherit from the parent.
This prevents the following two issues and allows us to remove the
NODE_IS_NATIVE_ANONYMOUS flag:
* Avoiding inheriting from the non-NAC ancestor in XBL bindings bound to NAC.
- This is no longer a problem since we apply the rule only if we're a
pseudo-element, and all pseudo-elements are in native anonymous subtrees.
- This also allows to remove the hack that propagates the
NODE_IS_NATIVE_ANONYMOUS flag from the ::cue pseudo-element from
BindToTree.
* Inheriting from the wrong thing if we're a nested NAC subtree.
- We no longer look past our NAC subtree, with the exception of
::-moz-number-text's pseudo-elements, for which we do want to propagate
::placeholder to.
A few rules from forms.css have been modified because they're useless or needed
to propagate stuff to the anonymous form control in input[type="number"] which
previously inherited from the input itself.
Bug: 1460382
Reviewed-by: heycam
MozReview-Commit-ID: IDKYt3EJtSH
Bug: 1463589 Reviewed-by: emilio MozReview-Commit-ID: 4fOqln3oOpC
Change mStopColor, mFloodColor, and mLightingColor in nsStyleSVGReset. Bug: 1457353 Reviewed-by: xidorn MozReview-Commit-ID: KMRMtHk1jNK
Bug: 1464496 Reviewed-by: emilio MozReview-Commit-ID: By9fV70Oq0K
…t it. Bug: 1466008 Reviewed-by: xidorn MozReview-Commit-ID: JyzwaRgf5Ct
Bug: 1466095 Reviewed-by: xidorn MozReview-Commit-ID: 2BmtSDPmHj9
…ce we use it. Though I think it may be slightly fishy if used in, e.g., a @Keyframes block. For our purposes right now it doesn't make a difference, I think. Bug: 1466008 MozReview-Commit-ID: A7VCTOqaIuB
That way we avoid cfg churn in WillChange stuff.
…code.
highfive
commented
Jun 2, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 2, 2018
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 2, 2018
style: sync changes from mozilla-central. See each individual commit for details.
|
|
|
@bors-servo retry #20734 |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
This was referenced Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJun 2, 2018
•
edited by SimonSapin
See each individual commit for details.
This change is