Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: sync changes from mozilla-central. #20900

Merged
merged 16 commits into from Jun 2, 2018
Merged

style: sync changes from mozilla-central. #20900

merged 16 commits into from Jun 2, 2018

Commits on Jun 2, 2018

  1. style: Create a stacking context for contain:paint. 

    Bug: 1463599
Reviewed-by: mattwoodrow
MozReview-Commit-ID: Ln72MOlHXwi
    @muhammedyusuf-sermet @emilio
    muhammedyusuf-sermet authored and emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    f0fbcf2

  2. style: Implement the smarter interporation for transform. 

    Corresponding to this spec change;
w3c/csswg-drafts@3281266

The expected value in test_transitions_per_property.html can be calculated;

  'start' + ('end' - 'start') * 0.25

Bug: 1464647
Reviewed-by: birtles, emilio
MozReview-Commit-ID: NI9gOUuPnG
    Hiroyuki Ikezoe @emilio
    Hiroyuki Ikezoe authored and emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    378fcc2

  3. style: trivial TopLevelRuleParser construction cleanup. 

    MozReview-Commit-ID: 5CdOdQPZzyb
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    e77a28d

  4. style: Don't let @namespace rules that aren't going to be inserted af… 

    …fect the namespace map.

Bug: 1464865
Reviewed-by: xidorn
MozReview-Commit-ID: 9bjlEBExqsr
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    142c9ec

  5. style: Some trivial cleanup. 

    Bug: 1464865
Reviewed-by: xidorn
MozReview-Commit-ID: 8ClaBR9ooGb
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    d5e19a1

  6. style: Cleanup transform animation. 

    Reviewed-by: hiro
But: 1465066
MozReview-Commit-ID: D9rq8CZIgf5
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    92e2adf

  7. style: Make element-backed pseudos inherit from NAC subtree roots and… 

    … other NAC inherit from their parents.

Currently, NAC always inherits from the closest non-NAC ancestor element,
regardless of whether it is for an element-backed pseudo or not.

This patch changes the inheritance so that for element-backed pseudos, we
inherit from the closest native anonymous root's parent, and for other NAC we
inherit from the parent.

This prevents the following two issues and allows us to remove the
NODE_IS_NATIVE_ANONYMOUS flag:

 * Avoiding inheriting from the non-NAC ancestor in XBL bindings bound to NAC.

   - This is no longer a problem since we apply the rule only if we're a
     pseudo-element, and all pseudo-elements are in native anonymous subtrees.

   - This also allows to remove the hack that propagates the
     NODE_IS_NATIVE_ANONYMOUS flag from the ::cue pseudo-element from
     BindToTree.

 * Inheriting from the wrong thing if we're a nested NAC subtree.

   - We no longer look past our NAC subtree, with the exception of
     ::-moz-number-text's pseudo-elements, for which we do want to propagate
     ::placeholder to.

A few rules from forms.css have been modified because they're useless or needed
to propagate stuff to the anonymous form control in input[type="number"] which
previously inherited from the input itself.

Bug: 1460382
Reviewed-by: heycam
MozReview-Commit-ID: IDKYt3EJtSH
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    5507d53

  8. style: Add contain:size and contain:content parsing functionality. 

    Bug: 1463589
Reviewed-by: emilio
MozReview-Commit-ID: 4fOqln3oOpC
    @MReschenberg @emilio
    MReschenberg authored and emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    0bfd1dc

  9. style: Change nscolor to StyleComplexColor in SVG properties. 

    Change mStopColor, mFloodColor, and mLightingColor in nsStyleSVGReset.

Bug: 1457353
Reviewed-by: xidorn
MozReview-Commit-ID: KMRMtHk1jNK
    @djg @emilio
    djg authored and emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    4108b1b

  10. style: Merge ServoDeclarationBlock and DeclarationBlock. 

    Bug: 1464496
Reviewed-by: emilio
MozReview-Commit-ID: By9fV70Oq0K
    @canova @emilio
    canova authored and emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    93472bc

  11. style: Make will-change honor prefs properly, and clean it up while a… 

    …t it.

Bug: 1466008
Reviewed-by: xidorn
MozReview-Commit-ID: JyzwaRgf5Ct
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    5db1387

  12. style: Make PropertyId::parse less of a footgun. 

    Bug: 1466095
Reviewed-by: xidorn
MozReview-Commit-ID: 2BmtSDPmHj9
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    600f195

  13. style: followup: set the rule type in the custom properties code, sin… 

    …ce we use it.

Though I think it may be slightly fishy if used in, e.g., a @Keyframes block.

For our purposes right now it doesn't make a difference, I think.

Bug: 1466008
MozReview-Commit-ID: A7VCTOqaIuB
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    8777c4e

  14. atoms: Add scroll-position as a static atom. 

    That way we avoid cfg churn in WillChange stuff.
    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    9bb7213

  15. dom: don't parse internal properties in CSSStyleDeclaration.

    @emilio
    emilio committed Jun 2, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    274bc4d

  16. layout_thread: Don't parse internal properties in paint registration … 

    …code.
    @emilio
    emilio committed Jun 2, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    97d8f6b
You can’t perform that action at this time.