Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority. #20901

Merged
merged 1 commit into from Jun 2, 2018
Merged

dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority. #20901

merged 1 commit into from Jun 2, 2018
+6 −97

Conversation

@emilio
Copy link
Member

emilio commented Jun 2, 2018 •
edited by SimonSapin

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.

This change is Reviewable
@highfive
Copy link

highfive commented Jun 2, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/cssstyledeclaration.rs
  • @fitzgen: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/cssstyledeclaration.rs
  • @KiChjang: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/cssstyledeclaration.rs
@highfive
Copy link

highfive commented Jun 2, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Jun 2, 2018

r? @nox or @jdm or @SimonSapin
@highfive highfive assigned nox and unassigned mbrubeck Jun 2, 2018
@emilio
Copy link
Member Author

emilio commented Jun 2, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

⌛ Trying commit 1210cc6 with merge f386f88...
bors-servo added a commit that referenced this pull request Jun 2, 2018
@bors-servo
Auto merge of #20901 - emilio:rm-setpropertyvalue, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f386f88 
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Jun 2, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

📌 Commit 1210cc6 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Jun 2, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Jun 2, 2018 

{"status": "FAIL", "group": "default", "message": "/_mozilla/css/setpropertypriority.html 8702dc9d5448a9b35232255293ad6d410b2fb14c\n/_mozilla/css/setpropertypriority_ref.html 29e1ae96db7c0c4964506ddc0f0e83feff4dea93\nTesting 8702dc9d5448a9b35232255293ad6d410b2fb14c == 29e1ae96db7c0c4964506ddc0f0e83feff4dea93", "stack": null, "subtest": null, "test": "/_mozilla/css/setpropertypriority.html", "line": 48117, "action": "test_result", "expected": "PASS"} {"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "Historical CSSStyleDeclaration member: setPropertyValue", "test": "/css/cssom/historical.html", "line": 116281, "action": "test_result", "expected": "FAIL"} {"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "Historical CSSStyleDeclaration member: setPropertyPriority", "test": "/css/cssom/historical.html", "line": 116282, "action": "test_result", "expected": "FAIL"}
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

☔ The latest upstream changes (presumably #20900) made this pull request unmergeable. Please resolve the merge conflicts.
@emilio emilio force-pushed the emilio:rm-setpropertyvalue branch from 1210cc6 to 64b2536 Jun 2, 2018
@emilio
Copy link
Member Author

emilio commented Jun 2, 2018

@bors-servo r=jdm

  • Removed the /_mozilla/ test, and updated the expectations to account for the new passes.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

📌 Commit 64b2536 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

⌛ Testing commit 64b2536 with merge 81a9f8a...
bors-servo added a commit that referenced this pull request Jun 2, 2018
@bors-servo
Auto merge of #20901 - emilio:rm-setpropertyvalue, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81a9f8a 
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20901)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

💔 Test failed - android
@emilio
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
aea5e14
@emilio emilio force-pushed the emilio:rm-setpropertyvalue branch from 64b2536 to aea5e14 Jun 2, 2018
@emilio
Copy link
Member Author

emilio commented Jun 2, 2018

@bors-servo r=jdm

  • manifest update.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

📌 Commit aea5e14 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

⌛ Testing commit aea5e14 with merge 5683f09...
bors-servo added a commit that referenced this pull request Jun 2, 2018
@bors-servo
Auto merge of #20901 - emilio:rm-setpropertyvalue, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5683f09 
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20901)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

💔 Test failed - mac-rel-wpt2
@CYBAI
Copy link
Collaborator

CYBAI commented Jun 2, 2018

@bors-servo retry

  • websocket failure
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 5683f09 to master...
@bors-servo bors-servo merged commit aea5e14 into servo:master Jun 2, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@emilio @highfive @bors-servo @jdm @CYBAI @mbrubeck @nox
You can’t perform that action at this time.