Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for worklet in globalscope #20905

Merged
merged 1 commit into from Jun 3, 2018
Merged

Fix typo for worklet in globalscope #20905

merged 1 commit into from Jun 3, 2018

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Jun 3, 2018 •
edited by SimonSapin

As the self will downcast to WorkletGlobalScope, I think it would be more reasonable to name the variable with worklet in if let.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it just renames the variable name

This change is Reviewable
@CYBAI
Fix typo for worklet
Loading status checks…
f2ad352
@highfive
Copy link

highfive commented Jun 3, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs
  • @fitzgen: components/script/dom/globalscope.rs
  • @KiChjang: components/script/dom/globalscope.rs
@highfive
Copy link

highfive commented Jun 3, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 3, 2018

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2018

📌 Commit f2ad352 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Jun 3, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2018

⌛ Testing commit f2ad352 with merge d23bc4f...
bors-servo added a commit that referenced this pull request Jun 3, 2018
@bors-servo
Auto merge of #20905 - CYBAI:fix-typo, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d23bc4f 
Fix typo for worklet in globalscope

As the `self` will downcast to `WorkletGlobalScope`, I think it would be more reasonable to name the variable with `worklet` in `if let`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it just renames the variable name

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Jun 3, 2018

@bors-servo retry
#20896
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing d23bc4f to master...
@bors-servo bors-servo merged commit f2ad352 into servo:master Jun 3, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI:fix-typo branch Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@CYBAI @highfive @jdm @bors-servo @nox
You can’t perform that action at this time.