Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EXT_shader_texture_lod #20915

Merged
merged 1 commit into from Jun 4, 2018
Merged

Implement EXT_shader_texture_lod #20915

merged 1 commit into from Jun 4, 2018

Conversation

@nox
Copy link
Member

nox commented Jun 4, 2018 •
edited by SimonSapin

This change is Reviewable
@nox
Implement EXT_shader_texture_lod
Loading status checks…
4e5e1e6
@highfive
Copy link

highfive commented Jun 4, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
  • @fitzgen: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
  • @KiChjang: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
@jdm
Copy link
Member

jdm commented Jun 4, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2018

📌 Commit 4e5e1e6 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2018

⌛ Testing commit 4e5e1e6 with merge 0b6df7e...
bors-servo added a commit that referenced this pull request Jun 4, 2018
@bors-servo
Auto merge of #20915 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b6df7e 
Implement EXT_shader_texture_lod

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20915)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Jun 4, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 0b6df7e to master...
@bors-servo bors-servo merged commit 4e5e1e6 into master Jun 4, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox mentioned this pull request Jun 5, 2018
Open
1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @highfive @jdm @bors-servo
You can’t perform that action at this time.