Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use new_debug_unreachable #20935

Merged
merged 1 commit into from Jun 6, 2018
Merged

Update dependencies to use new_debug_unreachable #20935

merged 1 commit into from Jun 6, 2018

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 6, 2018 •
edited by SimonSapin

Because reem/rust-debug-unreachable#6 makes debug_unreachable enable debug checks even in release builds since Rust 1.0.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they only change external code

This change is Reviewable
@highfive
Copy link

highfive commented Jun 6, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/values/computed/length.rs
  • @canaltinova: components/style/Cargo.toml, components/style/values/computed/length.rs
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml, components/style/values/computed/length.rs, components/layout/text.rs
@highfive
Copy link

highfive commented Jun 6, 2018

warning Warning warning

  • These commits modify style, layout, and gfx code, but no tests are modified. Please consider adding a test!
@mbrubeck
Update dependencies to use new_debug_unrechable
Loading status checks…
f6404f0 
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0.
@mbrubeck mbrubeck force-pushed the mbrubeck:deps branch from 10ba10e to f6404f0 Jun 6, 2018
@jdm
Copy link
Member

jdm commented Jun 6, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2018

📌 Commit f6404f0 has been approved by jdm
@highfive highfive assigned jdm and unassigned pcwalton Jun 6, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2018

⌛ Testing commit f6404f0 with merge 464a3ef...
bors-servo added a commit that referenced this pull request Jun 6, 2018
@bors-servo
Auto merge of #20935 - mbrubeck:deps, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
464a3ef 
Update dependencies to use new_debug_unreachable

Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only change external code

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20935)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 464a3ef to master...
@bors-servo bors-servo merged commit f6404f0 into servo:master Jun 6, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 6, 2018
Closed
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @highfive @jdm @bors-servo @pcwalton
You can’t perform that action at this time.