Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fontconfig submodule version to fix linker order bug #2096

Merged
merged 1 commit into from Apr 11, 2014
Merged

Update fontconfig submodule version to fix linker order bug #2096

merged 1 commit into from Apr 11, 2014

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 11, 2014

Please don't r+ until servo/rust-fontconfig#12 is merged.

r? @SimonSapin @mbrubeck

or whomever.
@larsbergstrom
Update fontconfig submodule version to fix linker order bug
Loading status checks…
9fa9959
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 11, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1235

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 9fa9959 Apr 11, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 9fa9959 Apr 11, 2014

saw approval from jdm
at larsbergstrom@9fa9959

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 11, 2014

merging larsbergstrom/servo/fix_fontconfig = 9fa9959 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 11, 2014

larsbergstrom/servo/fix_fontconfig = 9fa9959 merged ok, testing candidate = 2fcba6f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 11, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1203
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1157

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 11, 2014

fast-forwarding master to auto = 2fcba6f
bors-servo pushed a commit that referenced this pull request Apr 11, 2014
bors-servo
auto merge of #2096 : larsbergstrom/servo/fix_fontconfig, r=jdm
2fcba6f 
Please don't r+ until servo/rust-fontconfig#12 is merged.

r? @SimonSapin @mbrubeck

or whomever.
@bors-servo bors-servo merged commit 9fa9959 into servo:master Apr 11, 2014
1 check passed
1 check passed
default all tests passed
@larsbergstrom larsbergstrom deleted the larsbergstrom:fix_fontconfig branch Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@larsbergstrom @hoppipolla-critic-bot @bors-servo @jdm
You can’t perform that action at this time.