Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a safe, mostly-sound rooting rooting strategy. #2101

Merged
merged 16 commits into from May 3, 2014
Merged

Implement a safe, mostly-sound rooting rooting strategy. #2101

merged 16 commits into from May 3, 2014
+6,181 −3,902

Commits on May 3, 2014

  1. Turn on GC all the time. Fix rooting errors during parsing and storin… 

    …g timers. Fix borrow errors during tracing.
    @jdm
    jdm committed May 3, 2014
    ffdc3f5

  2. Implement safe rooting strategy via Unrooted, Root, JSRef, and JS.

    @jdm
    jdm committed May 3, 2014
    d7b96db

  3. Remove JS::get/get_mut to enforce sound rooting practices.

    @jdm
    jdm committed May 3, 2014
    dfdda00

  4. Move WebIDL methods to traits implemented by JSRef types.

    @jdm
    jdm committed May 3, 2014
    76783b0

  5. Remove abstract_self.

    @jdm
    jdm committed May 3, 2014
    7daa97c

  6. Move all methods on T to JSRef<T> or JS<T> as appropriate.

    @jdm
    jdm committed May 3, 2014
    1094109

  7. Allow controlling GC zeal via JS_GC_ZEAL environment variable.

    @jdm
    jdm committed May 3, 2014
    8e10dab

  8. Move stack roots into Root types instead of RootCollection, removing … 

    …the aribtrary 10 roots per stack frame restriction.
    @jdm
    jdm committed May 3, 2014
    bbfed38

  9. s/Unrooted/Temporary/g

    @jdm
    jdm committed May 3, 2014
    522d3f1

  10. Root Temporary values for the duration of their lifetime.

    @jdm
    jdm committed May 3, 2014
    a09a4bd

  11. Store per-ScriptTask RootCollection in TLS and use that in favour of … 

    …per-frame collections.
    @jdm
    jdm committed May 3, 2014
    aaf0a61

  12. Remove all root collections.

    @jdm
    jdm committed May 3, 2014
    7b3e6d1

  13. Address review comments.

    @jdm
    jdm committed May 3, 2014
    0f2d0b1

  14. Make dictionaries contain Root<T> values instead of JS<T>, ensuring t… 

    …hat they will not be collected while the dictionary is alive.
    @jdm
    jdm committed May 3, 2014
    895e9ee

  15. Fix up the virtual method unsoundness.

    @jdm
    jdm committed May 3, 2014
    46a33b4

  16. Address review comments.

    @jdm
    jdm committed May 3, 2014
    Loading status checks…
    5
    91278da
You can’t perform that action at this time.