Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921) #21034

nox · 2018-06-11T11:55:07Z

This change is

highfive · 2018-06-11T11:55:11Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webgl_extensions/ext/oeselementindexuint.rs
@KiChjang: components/script/dom/webgl_extensions/ext/oeselementindexuint.rs

highfive · 2018-06-11T11:55:12Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

KiChjang · 2018-06-11T17:57:50Z

@bors-servo r+

bors-servo · 2018-06-11T17:57:51Z

📌 Commit 046ee92 has been approved by KiChjang

bors-servo · 2018-06-11T17:57:57Z

⌛ Testing commit 046ee92 with merge 0fcc4c9...


        Auto merge of #21034 - servo:desktop-oes-element-index-uint, r=KiChjang

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21034)

bors-servo · 2018-06-11T18:17:39Z

💔 Test failed - linux-rel-css

KiChjang · 2018-06-11T18:20:20Z

{"status": "FAIL", "group": "default", "message": "assert_true: getError expected: INVALID_OPERATION. Was NO_ERROR :  expected true got false", "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:88:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1538:20\ntest@http://web-platform.test:8000/resources/testharness.js:548:9\nreportTestResultsToHarness@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:87:7\ntestFailed@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:159:5\nglErrorShouldBe@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1406:5\nrunIndexValidationTests@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html:304:5\n@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html:104:13\n", "subtest": "WebGL test #20: getError expected: INVALID_OPERATION. Was NO_ERROR : ", "test": "/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html", "line": 186196, "action": "test_result", "expected": "PASS"}
{"status": "FAIL", "group": "default", "message": "assert_true: getError expected: INVALID_OPERATION. Was NO_ERROR :  expected true got false", "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:88:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1538:20\ntest@http://web-platform.test:8000/resources/testharness.js:548:9\nreportTestResultsToHarness@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:87:7\ntestFailed@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/resources/js-test-pre.js:159:5\nglErrorShouldBe@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1406:5\nrunIndexValidationTests@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html:304:5\n@http://web-platform.test:8000/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html:104:13\n", "subtest": "WebGL test #64: getError expected: INVALID_OPERATION. Was NO_ERROR : ", "test": "/_mozilla/webgl/conformance-1.0.3/conformance/extensions/oes-element-index-uint.html", "line": 186240, "action": "test_result", "expected": "PASS"}

nox · 2018-06-12T10:33:18Z

This is #20599.


        Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)

nox · 2018-06-12T10:34:12Z

@bors-servo r=KiChjang

bors-servo · 2018-06-12T10:34:13Z

📌 Commit c7603bd has been approved by KiChjang

bors-servo · 2018-06-12T10:34:18Z

⌛ Testing commit c7603bd with merge 731f52c...


        Auto merge of #21034 - servo:desktop-oes-element-index-uint, r=KiChjang

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21034)

bors-servo · 2018-06-12T10:55:00Z

💔 Test failed - linux-rel-css

nox · 2018-06-13T08:22:39Z

@bors-servo retry #21041

bors-servo · 2018-06-13T08:22:47Z

⌛ Testing commit c7603bd with merge 5034b4b...


        Auto merge of #21034 - servo:desktop-oes-element-index-uint, r=KiChjang

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21034)

bors-servo · 2018-06-13T08:32:51Z

💔 Test failed - mac-dev-unit

nox · 2018-06-13T08:40:57Z

@bors-servo retry

Weird stack overflow.

bors-servo · 2018-06-13T08:41:03Z

⌛ Testing commit c7603bd with merge 3991595...


        Auto merge of #21034 - servo:desktop-oes-element-index-uint, r=KiChjang

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21034)

bors-servo · 2018-06-13T09:10:15Z

💔 Test failed - linux-rel-wpt

nox · 2018-06-13T09:11:27Z

@bors-servo retry #20734

bors-servo · 2018-06-13T09:11:36Z

⌛ Testing commit c7603bd with merge 5c4f54c...


        Auto merge of #21034 - servo:desktop-oes-element-index-uint, r=KiChjang

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21034)

bors-servo · 2018-06-13T09:34:17Z

💔 Test failed - linux-rel-css

nox · 2018-06-13T11:23:36Z

@bors-servo retry #20734

bors-servo · 2018-06-13T11:23:39Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt2...

bors-servo · 2018-06-13T12:01:16Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: KiChjang
Pushing 5c4f54c to master...

highfive assigned emilio Jun 11, 2018

highfive added the S-awaiting-review label Jun 11, 2018

KiChjang approved these changes Jun 11, 2018

View changes

highfive assigned KiChjang and unassigned emilio Jun 11, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 11, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 11, 2018

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921)

Loading status checks…

c7603bd

nox force-pushed the desktop-oes-element-index-uint branch from 046ee92 to c7603bd Jun 12, 2018

highfive added S-awaiting-review and removed S-tests-failed labels Jun 12, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 12, 2018

highfive removed the S-awaiting-merge label Jun 12, 2018

highfive added the S-tests-failed label Jun 12, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 13, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 13, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 13, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 13, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 13, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 13, 2018

SimonSapin deleted the desktop-oes-element-index-uint branch Aug 8, 2018

servo / servo

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921) #21034

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921) #21034

nox commented Jun 11, 2018 •

edited by SimonSapin

highfive commented Jun 11, 2018

highfive commented Jun 11, 2018

KiChjang commented Jun 11, 2018

bors-servo commented Jun 11, 2018

bors-servo commented Jun 11, 2018

bors-servo commented Jun 11, 2018

KiChjang commented Jun 11, 2018

nox commented Jun 12, 2018

nox commented Jun 12, 2018

bors-servo commented Jun 12, 2018

bors-servo commented Jun 12, 2018

bors-servo commented Jun 12, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

servo / servo

Join GitHub today

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921) #21034

Don't check for GL_OES_element_index_unit with desktop GL (fixes #20921) #21034

Conversation

nox commented Jun 11, 2018 • edited by SimonSapin

highfive commented Jun 11, 2018

highfive commented Jun 11, 2018

KiChjang commented Jun 11, 2018

bors-servo commented Jun 11, 2018

bors-servo commented Jun 11, 2018

bors-servo commented Jun 11, 2018

KiChjang commented Jun 11, 2018

nox commented Jun 12, 2018

nox commented Jun 12, 2018

bors-servo commented Jun 12, 2018

bors-servo commented Jun 12, 2018

bors-servo commented Jun 12, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 13, 2018

bors-servo commented Jun 13, 2018

bors-servo commented Jun 13, 2018

nox commented Jun 11, 2018 •

edited by SimonSapin