Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12) #21046

Merged
merged 1 commit into from Jun 14, 2018
Merged

Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12) #21046

merged 1 commit into from Jun 14, 2018
+21 −49

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 13, 2018 •
edited

This change is Reviewable
@highfive
Copy link

highfive commented Jun 13, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Jun 13, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Jun 13, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

📌 Commit d0f2868 has been approved by nox
@highfive highfive assigned nox and unassigned gw3583 Jun 13, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

⌛ Testing commit d0f2868 with merge bbe7e69...
bors-servo added a commit that referenced this pull request Jun 13, 2018
@bors-servo
Auto merge of #21046 - servo:stable-alloc, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bbe7e69 
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

💔 Test failed - windows-msvc-dev
@SimonSapin SimonSapin force-pushed the stable-alloc branch from d0f2868 to bdfef6c Jun 13, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 13, 2018

I don’t have easy access to my Windows machine this week, so trying something blindly… (Changed alloc_system::System to std::alloc::System.)

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

📌 Commit bdfef6c has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

⌛ Testing commit bdfef6c with merge 8be4e48...
bors-servo added a commit that referenced this pull request Jun 13, 2018
@bors-servo
Auto merge of #21046 - servo:stable-alloc, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8be4e48 
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

💔 Test failed - linux-rel-wpt
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 13, 2018

@bors-servo retry #21047
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

⌛ Testing commit bdfef6c with merge e4e932d...
bors-servo added a commit that referenced this pull request Jun 13, 2018
@bors-servo
Auto merge of #21046 - servo:stable-alloc, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e4e932d 
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2018

💔 Test failed - mac-dev-unit
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 13, 2018 

fatal runtime error: stack overflow
error: Could not compile `cssparser`.

Maybe servo/rust-cssparser#224 would help?
@SimonSapin
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)
Loading status checks…
c94c2b6
@SimonSapin SimonSapin force-pushed the stable-alloc branch from bdfef6c to c94c2b6 Jun 14, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 14, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

📌 Commit c94c2b6 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

⌛ Testing commit c94c2b6 with merge 98ac66d...
bors-servo added a commit that referenced this pull request Jun 14, 2018
@bors-servo
Auto merge of #21046 - servo:stable-alloc, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
98ac66d 
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Jun 14, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-dev-unit...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 98ac66d to master...
@bors-servo bors-servo merged commit c94c2b6 into master Jun 14, 2018
4 of 5 checks passed
4 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the stable-alloc branch Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @nox @bors-servo @jdm @gw3583
You can’t perform that action at this time.