Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12) #21046

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
6 participants
@SimonSapin
Copy link
Member

commented Jun 13, 2018

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 13, 2018

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Jun 13, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member

commented Jun 13, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

📌 Commit d0f2868 has been approved by nox

@highfive highfive assigned nox and unassigned gw3583 Jun 13, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

⌛️ Testing commit d0f2868 with merge bbe7e69...

bors-servo added a commit that referenced this pull request Jun 13, 2018

Auto merge of #21046 - servo:stable-alloc, r=nox
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

💔 Test failed - windows-msvc-dev

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2018

I don’t have easy access to my Windows machine this week, so trying something blindly… (Changed alloc_system::System to std::alloc::System.)

@bors-servo r=nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

📌 Commit bdfef6c has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

⌛️ Testing commit bdfef6c with merge 8be4e48...

bors-servo added a commit that referenced this pull request Jun 13, 2018

Auto merge of #21046 - servo:stable-alloc, r=nox
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

💔 Test failed - linux-rel-wpt

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

⌛️ Testing commit bdfef6c with merge e4e932d...

bors-servo added a commit that referenced this pull request Jun 13, 2018

Auto merge of #21046 - servo:stable-alloc, r=nox
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

💔 Test failed - mac-dev-unit

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2018

fatal runtime error: stack overflow
error: Could not compile `cssparser`.

Maybe servo/rust-cssparser#224 would help?

@SimonSapin SimonSapin force-pushed the stable-alloc branch from bdfef6c to c94c2b6 Jun 14, 2018

@taskcluster

This comment has been minimized.

Copy link

commented on c94c2b6 Jun 14, 2018

Submitting the task to Taskcluster failed. Details

You do not have sufficient scopes. You are missing the following scopes:

{
"AnyOf": [
{
"AnyOf": [
"queue:create-task:highest:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:very-high:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:high:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:medium:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:low:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:very-low:aws-provisioner-v1/servo-docker-worker",
"queue:create-task:lowest:aws-provisioner-v1/servo-docker-worker"
]
},
{
"AnyOf": [
"queue:create-task:aws-provisioner-v1/servo-docker-worker",
{
"AllOf": [
"queue:define-task:aws-provisioner-v1/servo-docker-worker",
"queue:task-group-id:taskcluster-github/ESpIocJIS9mi1Qn0okt3Zg",
"queue:schedule-task:taskcluster-github/ESpIocJIS9mi1Qn0okt3Zg/ESpIocJIS9mi1Qn0okt3Zg"
]
}
]
}
]
}

You have the scopes:

\[
  "assume:project:taskcluster:mozilla\-github\-repository",
  "assume:repo:github.com/servo/servo:pull\-request",
  "notify:email:\*",
  "notify:irc\-channel:\*",
  "notify:irc\-user:\*",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker\-windows",
  "queue:create\-task:aws\-provisioner\-v1/servo",
  "queue:create\-task:aws\-provisioner\-v1/win2012r2",
  "queue:route:garbage.\*",
  "queue:route:index.garbage.\*",
  "queue:route:notify.email.\*",
  "queue:route:notify.irc\-channel.\*",
  "queue:route:notify.irc\-user.\*",
  "queue:scheduler\-id:taskcluster\-github",
  "secrets:get:garbage/\*",
  "secrets:set:garbage/\*"
\]

This request requires you to satisfy this scope expression:

{
  "AllOf": \[
    {
      "AnyOf": \[
        {
          "AllOf": \[
            "queue:scheduler\-id:taskcluster\-github",
            {
              "AnyOf": \[
                "queue:create\-task:highest:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:medium:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:lowest:aws\-provisioner\-v1/servo\-docker\-worker"
              \]
            }
          \]
        },
        {
          "AnyOf": \[
            "queue:create\-task:aws\-provisioner\-v1/servo\-docker\-worker",
            {
              "AllOf": \[
                "queue:define\-task:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:task\-group\-id:taskcluster\-github/ESpIocJIS9mi1Qn0okt3Zg",
                "queue:schedule\-task:taskcluster\-github/ESpIocJIS9mi1Qn0okt3Zg/ESpIocJIS9mi1Qn0okt3Zg"
              \]
            }
          \]
        }
      \]
    }
  \]
}

method: createTask
errorCode: InsufficientScopes
statusCode: 403
time: 2018-06-14T02:19:46.644Z

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

@bors-servo r=nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

📌 Commit c94c2b6 has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

⌛️ Testing commit c94c2b6 with merge 98ac66d...

bors-servo added a commit that referenced this pull request Jun 14, 2018

Auto merge of #21046 - servo:stable-alloc, r=nox
Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21046)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

@bors-servo bors-servo merged commit c94c2b6 into master Jun 14, 2018

4 of 5 checks passed

Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the stable-alloc branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.