Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove components/nonzero, use std::num::NonZero instead #21058

Merged
merged 2 commits into from Jun 16, 2018
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 15, 2018

This change is Reviewable

@highfive
Copy link

highfive commented Jun 15, 2018

Heads up! This PR modifies the following files:

  • @edunham: servo-tidy.toml
  • @paulrouget: components/compositing/Cargo.toml, components/compositing/compositor.rs, components/compositing/lib.rs, components/servo/Cargo.toml
@SimonSapin SimonSapin mentioned this pull request Jun 15, 2018
4 of 4 tasks complete
@SimonSapin SimonSapin force-pushed the unnonzero branch from 3f667c9 to e39f741 Jun 15, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 16, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2018

📌 Commit e39f741 has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned nox Jun 16, 2018
bors-servo added a commit that referenced this pull request Jun 16, 2018
Remove components/nonzero, use std::num::NonZero instead

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21058)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2018

Testing commit e39f741 with merge 54d1a7f...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2018

💔 Test failed - mac-rel-wpt2

@jdm
Copy link
Member

jdm commented Jun 16, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2018

Testing commit e39f741 with merge 440e855...

bors-servo added a commit that referenced this pull request Jun 16, 2018
Remove components/nonzero, use std::num::NonZero instead

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21058)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2018

@bors-servo bors-servo merged commit e39f741 into master Jun 16, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Exception
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the unnonzero branch Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.