Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implement dirName #21084

Closed
wants to merge 1 commit into from
Closed

[WIP] implement dirName #21084

wants to merge 1 commit into from

Conversation

@tigercosmos
Copy link
Collaborator

tigercosmos commented Jun 22, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Jun 22, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmltextareaelement.rs, components/script/dom/htmlinputelement.rs, components/script/lib.rs, components/script/dom/webidls/HTMLTextAreaElement.webidl
  • @KiChjang: components/script/dom/htmltextareaelement.rs, components/script/dom/htmlinputelement.rs, components/script/lib.rs, components/script/dom/webidls/HTMLTextAreaElement.webidl
@highfive
Copy link

highfive commented Jun 22, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@tigercosmos
implement dirName
Loading status checks…
3b26029
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2018

☔ The latest upstream changes (presumably #21737) made this pull request unmergeable. Please resolve the merge conflicts.
@tigercosmos
Copy link
Collaborator Author

tigercosmos commented Sep 20, 2018

close due to no activity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-review S-needs-rebase S-work-in-progress
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tigercosmos @highfive @bors-servo @mbrubeck
You can’t perform that action at this time.