Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) #21089

SimonSapin · 2018-06-24T10:35:28Z

This change is

SimonSapin · 2018-06-24T10:35:41Z

bors-servo · 2018-06-24T10:35:42Z

📌 Commit 0e9bb15 has been approved by SimonSapin

bors-servo · 2018-06-24T10:35:47Z

⌛ Testing commit 0e9bb15 with merge 220c57a...


        Auto merge of #21089 - servo:rustup, r=SimonSapin

Upgrade to rustc 1.28.0-nightly (60efbdead 2018-06-23)

bors-servo · 2018-06-24T10:37:46Z

💔 Test failed - mac-rel-wpt3

SimonSapin · 2018-06-24T11:36:41Z

error: failed to run custom build command for `num-traits v0.2.4`
process didn't exit successfully: `/Users/servo/buildbot/slave/mac-rel-wpt3/build/target/release/build/num-traits-72f79a235bb89e1d/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)
--- stderr
2018-06-24 06:37:40.516 rustc[90440:3472023977] Metadata.framework [Error]: couldn't get the client port

warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `serde v1.0.66`
process didn't exit successfully: `/Users/servo/buildbot/slave/mac-rel-wpt3/build/target/release/build/serde-ad6fa6e51ed985ef/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)

That’s… worrying. It happened on multiple macos builders, but not all of them. I couldn’t reproduce on a macbook. And the code that seems relevant doesn’t use unsafe at all:

Looking more closely, segfaults occur on builders with macOS 10.10.5, not on those with 10.11.6.

SimonSapin · 2018-06-24T11:40:13Z

I can reproduce on servo-mac2 with ~/.cargo/bin/rustup run --install nightly-2018-06-24 cargo build --release in https://github.com/rust-num/num-traits, but not with nightly-2018-06-23. Commit range: rust-lang/rust@cbc4c83...60efbde

SimonSapin · 2018-06-24T11:59:52Z

Of the PRs merged in that range, I am fairly certain that those are unrelated to this segfault:

I think those are also unrelated (but less confident):

Which leaves rust-lang/rust#51580, touching 69 files in 19 commits to implement async/await syntax.

SimonSapin · 2018-06-24T15:16:28Z

Copying the executable to a macbook still crashes and I can run lldb:

% OUT_DIR=out lldb ./build-script-build
(lldb) target create "./build-script-build"
Current executable set to './build-script-build' (x86_64).
(lldb) run
Process 26746 launched: './build-script-build' (x86_64)
Process 26746 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x0000000100011c05 build-script-build`std::io::stdio::_print::h8f28cebade0a06e8 + 197
build-script-build`std::io::stdio::_print::h8f28cebade0a06e8:
->  0x100011c05 <+197>: movdqa 0x10(%rax), %xmm0
    0x100011c0a <+202>: xorps  %xmm1, %xmm1
    0x100011c0d <+205>: movaps %xmm1, 0x10(%rax)
    0x100011c11 <+209>: movl   $0x1, %ecx
Target 0: (build-script-build) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
  * frame #0: 0x0000000100011c05 build-script-build`std::io::stdio::_print::h8f28cebade0a06e8 + 197
    frame #1: 0x0000000100001ac9 build-script-build`build_script_build::main::h54ceeae90e07a9e4 + 841
    frame #2: 0x00000001000011c6 build-script-build`std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::h5948b85ff3b6f69c + 6
    frame #3: 0x0000000100017148 build-script-build`std::panicking::try::do_call::h586091eb2188e424 (.llvm.4887162513922290480) + 24
    frame #4: 0x0000000100023ccf build-script-build`__rust_maybe_catch_panic + 31
    frame #5: 0x000000010000eac2 build-script-build`std::rt::lang_start_internal::h5f9decd422205a6f + 242
    frame #6: 0x0000000100001d1c build-script-build`main + 44
    frame #7: 0x00007fffcd189235 libdyld.dylib`start + 1
    frame #8: 0x00007fffcd189235 libdyld.dylib`start + 1

I can reproduce with a program that does nothing but use println!.

SimonSapin · 2018-06-24T15:33:22Z

Filed rust-lang/rust#51758 upstream.

bors-servo · 2018-06-30T08:44:41Z

⌛ Testing commit 0e9bb15 with merge e67a9f2...


        Auto merge of #21089 - servo:rustup, r=SimonSapin

Upgrade to rustc 1.28.0-nightly (60efbdead 2018-06-23)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21089)

bors-servo · 2018-06-30T08:44:53Z

💔 Test failed - android

SimonSapin · 2018-07-04T20:32:32Z

rust-lang/rust#51828 seems to have fixed the underlying bug. Now waiting on a new Nightly, which is apparently blocked on rust-lang/rust#51677.


        Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06)

SimonSapin · 2018-07-07T11:07:18Z

@bors-servo r+

bors-servo · 2018-07-07T11:07:19Z

📌 Commit a09899b has been approved by SimonSapin

bors-servo · 2018-07-07T11:07:23Z

⌛ Testing commit a09899b with merge 11c5c87...


        Auto merge of #21089 - servo:rustup, r=SimonSapin

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06)  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21089)

bors-servo · 2018-07-07T11:33:19Z

💔 Test failed - mac-rel-css2

SimonSapin · 2018-07-07T13:11:00Z

ICE while building script, but only on one of the 6 mac builders. I couldn’t reproduce on a macbook or by SSH’ing into the same builder. Maybe it’s intermittent?

@bors-servo retry

thread 'main' panicked at 'You forgot to call `create_def_with_parent` or are lowering node ids that do not belong to the current owner', libcore/option.rs:960:5
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
   1: std::sys_common::backtrace::print
   2: std::panicking::default_hook::{{closure}}
   3: std::panicking::default_hook
   4: rustc::util::common::panic_hook
   5: std::panicking::rust_panic_with_hook
   6: std::panicking::continue_panic_fmt
   7: rust_begin_unwind
   8: core::panicking::panic_fmt
   9: core::option::expect_failed
  10: rustc::hir::lowering::LoweringContext::lower_node_id_with_owner
  11: <rustc::hir::lowering::LoweringContext::lower_crate::MiscCollector<'lcx, 'interner> as syntax::visit::Visitor<'lcx>>::visit_item
  12: syntax::visit::walk_item
  13: syntax::visit::walk_item
  14: syntax::visit::walk_item
  15: syntax::visit::walk_item
  16: syntax::visit::walk_item
  17: rustc::hir::lowering::lower_crate
  18: rustc::util::common::time
  19: rustc_driver::driver::phase_2_configure_and_expand
  20: rustc_driver::driver::compile_input
  21: rustc_driver::run_compiler_with_pool
  22: <scoped_tls::ScopedKey<T>>::set
  23: <scoped_tls::ScopedKey<T>>::set
  24: syntax::with_globals
  25: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  26: __rust_maybe_catch_panic
  27: rustc_driver::run
  28: rustc_driver::main
  29: std::rt::lang_start::{{closure}}
  30: std::panicking::try::do_call
  31: __rust_maybe_catch_panic
  32: std::rt::lang_start_internal
  33: main
query stack during panic:
end of query stack

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.29.0-nightly (e06c87544 2018-07-06) running on x86_64-apple-darwin

note: compiler flags: -C opt-level=3 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `script`.

bors-servo · 2018-07-07T13:11:04Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt1, mac-rel-wpt4...

bors-servo · 2018-07-07T14:24:36Z

💔 Test failed - mac-rel-wpt1

SimonSapin · 2018-07-07T16:09:52Z

No ICE this time.

@bors-servo retry #20734

bors-servo · 2018-07-07T16:09:55Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

bors-servo · 2018-07-07T17:07:59Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 11c5c87 to master...

highfive assigned emilio Jun 24, 2018

highfive added the S-awaiting-review label Jun 24, 2018

highfive assigned SimonSapin and unassigned emilio Jun 24, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 24, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 24, 2018

This was referenced Jun 24, 2018

Update all Macs to 10.11 servo/saltfs#811

Closed

async/await rust-lang/rust#51580

Merged

SimonSapin mentioned this pull request Jun 24, 2018

println! segfaults with nightly-2018-06-24 on macOS 10.10 rust-lang/rust#51758

Closed

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 30, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 30, 2018

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06)

Loading status checks…

a09899b

SimonSapin changed the title ~~Upgrade to rustc 1.28.0-nightly (60efbdead 2018-06-23)~~ Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) Jul 7, 2018

SimonSapin force-pushed the rustup branch from 0e9bb15 to a09899b Jul 7, 2018

highfive added S-awaiting-review and removed S-tests-failed labels Jul 7, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 7, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 7, 2018

highfive added the S-tests-failed label Jul 7, 2018

SimonSapin deleted the rustup branch Jul 7, 2018

servo / servo

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) #21089

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) #21089

SimonSapin commented Jun 24, 2018 •

edited

SimonSapin commented Jun 24, 2018

bors-servo commented Jun 24, 2018

bors-servo commented Jun 24, 2018

bors-servo commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

bors-servo commented Jun 30, 2018

bors-servo commented Jun 30, 2018

SimonSapin commented Jul 4, 2018 •

edited

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

servo / servo

Join GitHub today

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) #21089

Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) #21089

Conversation

SimonSapin commented Jun 24, 2018 • edited

SimonSapin commented Jun 24, 2018

bors-servo commented Jun 24, 2018

bors-servo commented Jun 24, 2018

bors-servo commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

SimonSapin commented Jun 24, 2018

bors-servo commented Jun 30, 2018

bors-servo commented Jun 30, 2018

SimonSapin commented Jul 4, 2018 • edited

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

SimonSapin commented Jul 7, 2018

bors-servo commented Jul 7, 2018

bors-servo commented Jul 7, 2018

SimonSapin commented Jun 24, 2018 •

edited

SimonSapin commented Jul 4, 2018 •

edited