Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR, image (instance size optimizations). #21096

Closed
wants to merge 1 commit into from
Closed

Update WR, image (instance size optimizations). #21096

wants to merge 1 commit into from

Conversation

@gw3583
Copy link
Contributor

gw3583 commented Jun 27, 2018 •
edited by SimonSapin

This change is Reviewable
@gw3583
Update WR, image (instance size optimizations).
Loading status checks…
c0ff888
@highfive
Copy link

highfive commented Jun 27, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.
@highfive
Copy link

highfive commented Jun 27, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs, components/script/Cargo.toml, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @paulrouget: components/compositing/Cargo.toml, components/compositing/compositor.rs
  • @KiChjang: components/script/Cargo.toml, components/net_traits/Cargo.toml
@highfive
Copy link

highfive commented Jun 27, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gw3583
Copy link
Contributor Author

gw3583 commented Jun 27, 2018

r? @jdm or @mbrubeck

We finally landed a WR update earlier today so let's update to current master while we're on a roll.
@highfive highfive assigned jdm and unassigned asajeffrey Jun 27, 2018
@asajeffrey
asajeffrey approved these changes Jun 27, 2018
View changes
Copy link
Member

asajeffrey left a comment

@bors-servo: r+
@gw3583
Copy link
Contributor Author

gw3583 commented Jun 28, 2018

@bors-servo r=asajeffrey

@asajeffrey bors doesn't listen to messages sent in the GH review box 💩
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2018

📌 Commit c0ff888 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned jdm Jun 28, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2018

⌛ Testing commit c0ff888 with merge a21742f...
bors-servo added a commit that referenced this pull request Jun 28, 2018
@bors-servo
Auto merge of #21096 - gw3583:update-wr-again, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a21742f 
Update WR, image (instance size optimizations).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21096)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2018

💔 Test failed - mac-rel-css1
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

⌛ Testing commit c0ff888 with merge 1040dfa...
bors-servo added a commit that referenced this pull request Jun 30, 2018
@bors-servo
Auto merge of #21096 - gw3583:update-wr-again, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1040dfa 
Update WR, image (instance size optimizations).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21096)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

💔 Test failed - android
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2018

☔ The latest upstream changes (presumably #21087) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2018

🔒 Merge conflict
@gw3583
Copy link
Contributor Author

gw3583 commented Jul 16, 2018

Closing in favor of #21182.
@gw3583 gw3583 closed this Jul 16, 2018
@gw3583 gw3583 deleted the gw3583:update-wr-again branch Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@gw3583 @highfive @bors-servo @asajeffrey @jdm
You can’t perform that action at this time.