Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mozjs_sys to v0.51.3 #21102

Merged
merged 1 commit into from Jun 30, 2018
Merged

Updated mozjs_sys to v0.51.3 #21102

merged 1 commit into from Jun 30, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 29, 2018 •
edited by SimonSapin

Allows building servo for target i686-linux-android.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21093
  • These changes do not require tests because deperndency update

This change is Reviewable
@SimonSapin
Copy link
Member

SimonSapin commented Jun 29, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2018

📌 Commit 4966c94 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned nox Jun 29, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2018

⌛ Testing commit 4966c94 with merge 462b853...
bors-servo added a commit that referenced this pull request Jun 29, 2018
@bors-servo
Auto merge of #21102 - asajeffrey:mozjs-sys-0.51.3, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
462b853 
Updated mozjs_sys to v0.51.3

<!-- Please describe your changes on the following line: -->

Allows building servo for target `i686-linux-android`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21093
- [X] These changes do not require tests because deperndency update

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

SimonSapin commented Jun 29, 2018 •
edited

homu says this is pending but buildbot seems to have not be notified at all.

@bors-servo r-
@SimonSapin SimonSapin force-pushed the asajeffrey:mozjs-sys-0.51.3 branch from 4966c94 to bf42577 Jun 29, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Jun 29, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2018

📌 Commit bf42577 has been approved by SimonSapin
@mbrubeck mbrubeck closed this Jun 29, 2018
@mbrubeck mbrubeck reopened this Jun 29, 2018
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 29, 2018

@bors-servo retry
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 29, 2018

@bors-servo r- force clean
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 29, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2018

📌 Commit bf42577 has been approved by mbrubeck
@highfive highfive assigned mbrubeck and unassigned SimonSapin Jun 29, 2018
@SimonSapin SimonSapin mentioned this pull request Jun 29, 2018
Merged
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 30, 2018

Hmm, even force cleaning it doesn't seem to have helped.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

⌛ Testing commit bf42577 with merge 299cd13...
bors-servo added a commit that referenced this pull request Jun 30, 2018
@bors-servo
Auto merge of #21102 - asajeffrey:mozjs-sys-0.51.3, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
299cd13 
Updated mozjs_sys to v0.51.3

<!-- Please describe your changes on the following line: -->

Allows building servo for target `i686-linux-android`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21093
- [X] These changes do not require tests because deperndency update

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

💔 Test failed - android
@SimonSapin
Copy link
Member

SimonSapin commented Jun 30, 2018

@bors-servo retry

#21108
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

⚡ Previous build results for linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only android, arm32, arm64, mac-rel-wpt2, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

💔 Test failed - mac-rel-wpt4
@SimonSapin
Copy link
Member

SimonSapin commented Jun 30, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

⚡ Previous build results for linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only android, arm32, arm64, mac-rel-wpt4...
@asajeffrey @SimonSapin
Updated mozjs_sys to v0.51.3
Loading status checks…
a557e2f
@SimonSapin SimonSapin force-pushed the asajeffrey:mozjs-sys-0.51.3 branch from bf42577 to a557e2f Jun 30, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Jun 30, 2018

Only the mac job ever started… Pushing yet another trivially-amended commit to try get homu/buildbot more into a known state.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

📌 Commit a557e2f has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned mbrubeck Jun 30, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

⌛ Testing commit a557e2f with merge 9c243a1...
bors-servo added a commit that referenced this pull request Jun 30, 2018
@bors-servo
Auto merge of #21102 - asajeffrey:mozjs-sys-0.51.3, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c243a1 
Updated mozjs_sys to v0.51.3

<!-- Please describe your changes on the following line: -->

Allows building servo for target `i686-linux-android`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21093
- [X] These changes do not require tests because deperndency update

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 9c243a1 to master...
@bors-servo bors-servo merged commit a557e2f into servo:master Jun 30, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: Exception
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 30, 2018
Merged
4 of 4 tasks complete
@SimonSapin SimonSapin mentioned this pull request Jun 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

mozjs_sys + target=android-i686: Rust compilation error
6 participants
@asajeffrey @SimonSapin @bors-servo @mbrubeck @nox @highfive
You can’t perform that action at this time.