Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowProxy support and basic browsing context concept. #2111

Merged
merged 1 commit into from Apr 22, 2014
Merged

Add WindowProxy support and basic browsing context concept. #2111

merged 1 commit into from Apr 22, 2014

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 15, 2014

No description provided.

@highfive
Copy link

highfive commented Apr 15, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 15, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1260

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Remove all traces of WindowProxy. Implement basic browser context con…
Loading status checks…
94dffca 
…cept and outerizing of inner windows.
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Collaborator

Ms2ger commented on 94dffca Apr 22, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 94dffca Apr 22, 2014

saw approval from Ms2ger
at jdm@94dffca

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 22, 2014

merging jdm/servo/browsercontext = 94dffca into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 22, 2014

jdm/servo/browsercontext = 94dffca merged ok, testing candidate = bdcd8dd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 22, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1263
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1217

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 22, 2014

fast-forwarding master to auto = bdcd8dd
bors-servo pushed a commit that referenced this pull request Apr 22, 2014
bors-servo
auto merge of #2111 : jdm/servo/browsercontext, r=Ms2ger
bdcd8dd
@bors-servo bors-servo merged commit 94dffca into servo:master Apr 22, 2014
1 check passed
1 check passed
default all tests passed
@jdm jdm mentioned this pull request Apr 22, 2014
Closed
@jdm jdm deleted the jdm:browsercontext branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @hoppipolla-critic-bot @bors-servo @jdm
You can’t perform that action at this time.