Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk and Gradle update #21160

Closed
wants to merge 8 commits into from
Closed

Sdk and Gradle update #21160

wants to merge 8 commits into from

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jul 11, 2018 •
edited by SimonSapin

Fix #21147. Depends on #20912

This change is Reviewable
paulrouget added 5 commits Jun 4, 2018
@paulrouget
Remove Android code from /ports/servo/
d78cc9b
@paulrouget
introduce a simple servo library
b7348f2
@paulrouget
minimal Android app that relies on libsimpleservo
dab401b
@paulrouget
update fakeld
23cd752
@paulrouget
fix android build
Loading status checks…
98af35b
@highfive
Copy link

highfive commented Jul 11, 2018

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/bootstrap_commands.py, python/servo/command_base.py, python/servo/testing_commands.py, python/servo/package_commands.py, python/servo/build_commands.py and 1 more
  • @edunham: appveyor.yml
  • @aneeshusa: etc/ci/buildbot_steps.yml
@highfive
Copy link

highfive commented Jul 11, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@paulrouget paulrouget changed the title [WIP] Sdk update [WIP] Sdk and Gradle update Jul 11, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 11, 2018

Only last commit matter.

@MortimerGoro Is that all that's needed?
@paulrouget paulrouget mentioned this pull request Jul 11, 2018
Closed
@paulrouget paulrouget force-pushed the paulrouget:sdk_update branch 2 times, most recently from 17011df to d95bb36 Jul 11, 2018
@paulrouget
Only compile ports/servo on Linux
Loading status checks…
16136c0
@paulrouget paulrouget force-pushed the paulrouget:sdk_update branch from d95bb36 to 2c58755 Jul 11, 2018
@paulrouget paulrouget changed the title [WIP] Sdk and Gradle update Sdk and Gradle update Jul 11, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 11, 2018 •
edited

@MortimerGoro r? (only the last commit)
paulrouget added 2 commits Jul 12, 2018
@paulrouget
address review comments
Loading status checks…
5410512
@paulrouget
Update Gradle and SDK
Loading status checks…
23c4f6f
@paulrouget paulrouget force-pushed the paulrouget:sdk_update branch from 2c58755 to 23c4f6f Jul 13, 2018
@MortimerGoro
Copy link
Contributor

MortimerGoro commented Jul 13, 2018

@paulrouget looks good to me
@paulrouget paulrouget mentioned this pull request Jul 13, 2018
Merged
0 of 5 tasks complete
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 18, 2018

Closing as this will land with #20912
@paulrouget paulrouget closed this Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MortimerGoro MortimerGoro

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@paulrouget @highfive @MortimerGoro @avadacatavra
You can’t perform that action at this time.