Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a no-op 'android-x86' set of Buildbot steps #21162

Merged
merged 1 commit into from Jul 12, 2018
Merged

Add a no-op 'android-x86' set of Buildbot steps #21162

merged 1 commit into from Jul 12, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 11, 2018 •
edited

This seems to exist before we configure Buildbot to look for it. Actual compilation and testing steps will be added once Buildbot is configured to run them.

CC #21124, #21116.

This change is Reviewable
@SimonSapin
Add a no-op 'android-x86' set of Buildbot steps
Loading status checks…
b25483d 
This seems to exist before we configure Buildbot to look for it.
Actual compilation and testing steps will be added once Buildbot
is configured to run them.

CC #21124,
#21116
@highfive
Copy link

highfive commented Jul 11, 2018

Heads up! This PR modifies the following files:
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

📌 Commit b25483d has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned jdm Jul 11, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 11, 2018

This blocks an upcoming Saltfs PR, which will in turn block the next servo/servo PR for this task:

@bors-servo p=1
@SimonSapin SimonSapin mentioned this pull request Jul 11, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

⌛ Testing commit b25483d with merge 27a7f67...
bors-servo added a commit that referenced this pull request Jul 11, 2018
@bors-servo
Auto merge of #21162 - servo:android-x86-noop, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27a7f67 
Add a no-op 'android-x86' set of Buildbot steps

This seems to exist before we configure Buildbot to look for it. Actual compilation and testing steps will be added once Buildbot is configured to run them.

CC #21124, #21116.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21162)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

💔 Test failed - mac-rel-wpt4
@jdm
Copy link
Member

jdm commented Jul 11, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

⌛ Testing commit b25483d with merge b411536...
bors-servo added a commit that referenced this pull request Jul 11, 2018
@bors-servo
Auto merge of #21162 - servo:android-x86-noop, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b411536 
Add a no-op 'android-x86' set of Buildbot steps

This seems to exist before we configure Buildbot to look for it. Actual compilation and testing steps will be added once Buildbot is configured to run them.

CC #21124, #21116.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21162)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

💔 Test failed - mac-rel-wpt4
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 11, 2018

@bors-servo retry #20685
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing b411536 to master...
@bors-servo bors-servo merged commit b25483d into master Jul 12, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit to servo/saltfs that referenced this pull request Jul 12, 2018
@bors-servo
Auto merge of #852 - servo:kvm, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20c0a8f 
Add the android-x86 build job

CC servo/servo#21124

Should not be deployed before servo/servo#21162 lands, as that would likely break all builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/852)
<!-- Reviewable:end -->
@SimonSapin SimonSapin deleted the android-x86-noop branch Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @highfive @bors-servo @jdm
You can’t perform that action at this time.