Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse remote-event task source in EventSource #21170
Merged
Conversation
highfive
commented
Jul 13, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 13, 2018
|
|
gterzian
changed the title
gterzian
force-pushed the
gterzian:use_remote_event_task_source_for_eventsource
branch
from
0ff2251
to
dbf1ae1
| @@ -482,8 +483,6 @@ impl EventSource { | |||
| data: String::new(), | |||
| last_event_id: String::new(), | |||
| }; | |||
| // TODO: use the "remote event task source", and canceller. | |||
| // https://html.spec.whatwg.org/multipage/#remote-event-task-source | |||
This comment has been minimized.
This comment has been minimized.
gterzian
Jul 13, 2018
•
Author
Member
This comment is a mistake I introduced in #21126, the networking source is the right one here, since it's a plain fetch and not an event-source 'task', see https://html.spec.whatwg.org/multipage/server-sent-events.html#dom-eventsource
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21111 in the context of #21114 Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
|
|
gterzian
force-pushed the
gterzian:use_remote_event_task_source_for_eventsource
branch
from
dbf1ae1
to
baef63b
|
Sorry for the tidy error... |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21114 in the context of #21111. Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 14, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21114 in the context of #21111. Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
|
|
This was referenced Jul 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gterzian commentedJul 13, 2018
•
edited
Follow up on #21126, this again 'changes nothing', but will be useful for #21114 in the context of #21111.
Trying to break up work into smaller PR's ;)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is