Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReintroducing parse_a_sizes along with tests #21178
Conversation
highfive
commented
Jul 14, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
a890240
to
e3f97a3
| }, | ||
| None => SourceSizeList { | ||
| source_sizes: vec![], | ||
| value: Some(Length::NoCalc(NoCalcLength::ViewportPercentage(ViewportPercentageLength::Vw(100.)))) |
This comment has been minimized.
This comment has been minimized.
emilio
Jul 15, 2018
Member
Also note that this is not needed, SourceSizeList::evaluate already handles this correctly.
|
|
||
|
|
||
| #[test] | ||
| fn no_default_provided() { |
This comment has been minimized.
This comment has been minimized.
emilio
Jul 16, 2018
Member
I think I'd prefer to remove the unit tests and make the SourceSizeList and SourceSize fields private again, given there's a few tests that check all this in WPT: https://wpt.fyi/results/html/semantics/embedded-content/the-img-element/sizes
This comment has been minimized.
This comment has been minimized.
jdm
Jul 16, 2018
Member
I would prefer to retain the unit tests for the time being until we finish implementing all the pieces that are required in order for the WPT tests to actually work in Servo.
This comment has been minimized.
This comment has been minimized.
emilio
Jul 16, 2018
Member
That means that when I change SourceSizeList in Gecko I need to update all the tests, which is cumbersome given this is tested already there... :/
This comment has been minimized.
This comment has been minimized.
jdm
Jul 17, 2018
Member
Ok, that's a reasonable argument against these changes. @paavininanda Let's undo the changes that were made to support re-adding the unit tests, and remove the unit tests. This PR can just focus on adding the parse_a_sizes_attribute function without using it anywhere.
|
|
||
|
|
||
| #[test] | ||
| fn no_default_provided() { |
This comment has been minimized.
This comment has been minimized.
jdm
Jul 17, 2018
Member
Ok, that's a reasonable argument against these changes. @paavininanda Let's undo the changes that were made to support re-adding the unit tests, and remove the unit tests. This PR can just focus on adding the parse_a_sizes_attribute function without using it anywhere.
cc30565
to
26e2241
26e2241
to
d2f467c
|
Since this is part of #21181 which makes use of it, let's just wait for that PR to merge. |
paavininanda commentedJul 14, 2018
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is