Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: run ./mach package implicitly after ./mach build #21183

Merged
merged 1 commit into from Jul 16, 2018

Conversation

Projects
None yet
5 participants
@SimonSapin
Copy link
Member

commented Jul 16, 2018

The result of ./mach build for Android is a .so file that cannot be used on its own, so running build without package is presumably never useful.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 16, 2018

Heads up! This PR modifies the following files:

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

@highfive highfive assigned paulrouget and unassigned mbrubeck Jul 16, 2018

@paulrouget

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

Will there still be a way to build without packaging?

I do build the .so regularly without running the final apk, for example to test that my code compiles. Adding a ~40s step after each successful build might be annoying.

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

Right now in this PR there is not, but I can add it. Is it really 40 seconds? package runs much quicker for me when everything is up to date.

To test that code compiles, wouldn’t ./mach check work as well? (And be faster?)

@paulrouget

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

It's 40s after #20912 lands.

And yes, mach check would work.

@paulrouget

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

r+

Android: run ./mach package implicitly after ./mach build by default
The result of `./mach build` for Android is a `.so` file
that cannot be used on its own, so running build without package
is presumably never useful.

@SimonSapin SimonSapin force-pushed the build-package branch from 1306306 to 6ef56da Jul 16, 2018

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

Added --no-package.

@bors-servo r=paulrouget

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

📌 Commit 6ef56da has been approved by paulrouget

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

⌛️ Testing commit 6ef56da with merge d8f57d8...

bors-servo added a commit that referenced this pull request Jul 16, 2018

Auto merge of #21183 - servo:build-package, r=paulrouget
Android: run ./mach package implicitly after ./mach build

The result of `./mach build` for Android is a `.so` file that cannot be used on its own, so running build without package is presumably never useful.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21183)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

💔 Test failed - mac-rel-css1

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

💔 Test failed - mac-rel-css1

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

error: Could not compile `script`.

To learn more, run the command again with --verbose.

No other error message :/

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

⌛️ Testing commit 6ef56da with merge 1fabd10...

bors-servo added a commit that referenced this pull request Jul 16, 2018

Auto merge of #21183 - servo:build-package, r=paulrouget
Android: run ./mach package implicitly after ./mach build

The result of `./mach build` for Android is a `.so` file that cannot be used on its own, so running build without package is presumably never useful.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21183)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

@bors-servo bors-servo merged commit 6ef56da into master Jul 16, 2018

3 of 5 checks passed

Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the build-package branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.