Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Salt-installed Android SDK on CI #21185

Merged
merged 1 commit into from Jul 18, 2018
Merged

Stop using Salt-installed Android SDK on CI #21185

merged 1 commit into from Jul 18, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 16, 2018 •
edited

This change is Reviewable
@SimonSapin
Stop using Salt-installed Android SDK on CI
Loading status checks…
e38a45b
@highfive
Copy link

highfive commented Jul 16, 2018

Heads up! This PR modifies the following files:
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 16, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2018

⌛ Trying commit e38a45b with merge 86c8bc1...
bors-servo added a commit that referenced this pull request Jul 16, 2018
@bors-servo
Auto merge of #21185 - servo:bootstrapped-android, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86c8bc1 
Stop using Salt-installed Android SDK on CI
@SimonSapin SimonSapin mentioned this pull request Jul 16, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 16, 2018

r? @paulrouget

I think this makes servo/saltfs#856 unnecessary. (The same change can be done in python/servo/bootstrap_commands.py instead.) In what order do you prefer to do things?
@paulrouget
Copy link
Contributor

paulrouget commented Jul 17, 2018 •
edited

This will make part of it unnecessary. We still need java 8. But it's a good step forward.

Where is bootstrap-android-and-accept-licences.sh coming from?
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 18, 2018

I’ll take this as approval :)

@bors-servo r=paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

📌 Commit e38a45b has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

⌛ Testing commit e38a45b with merge d25bd95...
bors-servo added a commit that referenced this pull request Jul 18, 2018
@bors-servo
Auto merge of #21185 - servo:bootstrapped-android, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d25bd95 
Stop using Salt-installed Android SDK on CI

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21185)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing d25bd95 to master...
@bors-servo bors-servo merged commit e38a45b into master Jul 18, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 18, 2018
Merged
4 of 4 tasks complete
@SimonSapin SimonSapin deleted the bootstrapped-android branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @highfive @bors-servo @paulrouget
You can’t perform that action at this time.