Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hittesting on HiDPI screens #21190

Merged
merged 1 commit into from Jul 17, 2018
Merged

Fix hittesting on HiDPI screens #21190

merged 1 commit into from Jul 17, 2018

Conversation

@jdm
Copy link
Member

jdm commented Jul 17, 2018 •
edited by SimonSapin

This fixes some regressions introduced in #21087 due to treating logical coordinates as physical ones without converting between them correctly.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21168
  • These changes do not require tests because we do not have the ability to test embedding input yet.

This change is Reviewable
@jdm
Convert logical glutin coordinates to physical coordinates for input …
Loading status checks…
b260052 
…events.
@highfive
Copy link

highfive commented Jul 17, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

r? @gw3583
@highfive highfive assigned gw3583 and unassigned nox Jul 17, 2018
@gw3583
Copy link
Contributor

gw3583 commented Jul 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

📌 Commit b260052 has been approved by gw3583
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⌛ Testing commit b260052 with merge 0f04670...
bors-servo added a commit that referenced this pull request Jul 17, 2018
@bors-servo
Auto merge of #21190 - jdm:lets-get-physical, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f04670 
Fix hittesting on HiDPI screens

This fixes some regressions introduced in #21087 due to treating logical coordinates as physical ones without converting between them correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21168
- [x] These changes do not require tests because we do not have the ability to test embedding input yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21190)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1...
@jdm jdm closed this Jul 17, 2018
@jdm jdm reopened this Jul 17, 2018
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⌛ Testing commit b260052 with merge a55cbc6...
bors-servo added a commit that referenced this pull request Jul 17, 2018
@bors-servo
Auto merge of #21190 - jdm:lets-get-physical, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a55cbc6 
Fix hittesting on HiDPI screens

This fixes some regressions introduced in #21087 due to treating logical coordinates as physical ones without converting between them correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21168
- [x] These changes do not require tests because we do not have the ability to test embedding input yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21190)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: gw3583
Pushing a55cbc6 to master...
@bors-servo bors-servo merged commit b260052 into servo:master Jul 17, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gw3583 gw3583

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Hit testing is offset in GL aquarium
5 participants
@jdm @highfive @gw3583 @bors-servo @nox
You can’t perform that action at this time.