Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate virtualenv from scratch when syncing WPT #21193

Merged
merged 2 commits into from Jul 17, 2018
Merged

Recreate virtualenv from scratch when syncing WPT #21193

merged 2 commits into from Jul 17, 2018

Conversation

@jdm
Copy link
Member

jdm commented Jul 17, 2018 •
edited by edunham

This fixes #21180 and attempts to work around #21145.

This change is Reviewable
jdm added 2 commits Jul 17, 2018
@jdm
Recreate virtualenv from scratch when syncing WPT
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1f4604
@jdm
Revert f37699d to fix perf test.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8084cf8
@highfive
Copy link

highfive commented Jul 17, 2018

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/buildbot_steps.yml, etc/ci/performance/test_perf.sh
@asajeffrey
Copy link
Member

asajeffrey commented Jul 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

📌 Commit 8084cf8 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned avadacatavra Jul 17, 2018
bors-servo added a commit that referenced this pull request Jul 17, 2018
@bors-servo
Auto merge of #21193 - servo:jdm-patch-17, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29c8db4 
Recreate virtualenv from scratch when syncing WPT

This fixes #21180 and attempts to work around #21145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21193)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⌛ Testing commit 8084cf8 with merge 29c8db4...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

💔 Test failed - mac-rel-wpt4
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry
bors-servo added a commit that referenced this pull request Jul 17, 2018
@bors-servo
Auto merge of #21193 - servo:jdm-patch-17, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8866491 
Recreate virtualenv from scratch when syncing WPT

This fixes #21180 and attempts to work around #21145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21193)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

⌛ Testing commit 8084cf8 with merge 8866491...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 8866491 to master...
@bors-servo bors-servo merged commit 8084cf8 into master Jul 17, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-17 branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

perf test is broken
5 participants
@jdm @highfive @asajeffrey @bors-servo @avadacatavra
You can’t perform that action at this time.