Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreate virtualenv from scratch when syncing WPT #21193

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Recreate virtualenv from scratch when syncing WPT #21193

merged 2 commits into from
Jul 17, 2018

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 17, 2018 •
edited by edunham

This fixes #21180 and attempts to work around #21145.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/buildbot_steps.yml, etc/ci/performance/test_perf.sh

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 17, 2018
@asajeffrey
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 8084cf8 has been approved by asajeffrey

@highfive highfive assigned asajeffrey and unassigned avadacatavra Jul 17, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 17, 2018
bors-servo pushed a commit that referenced this pull request Jul 17, 2018
Auto merge of #21193 - servo:jdm-patch-17, r=asajeffrey
29c8db4 
Recreate virtualenv from scratch when syncing WPT

This fixes #21180 and attempts to work around #21145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21193)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 8084cf8 with merge 29c8db4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 17, 2018
@jdm
Copy link
Member Author

jdm commented Jul 17, 2018

@bors-servo retry

bors-servo pushed a commit that referenced this pull request Jul 17, 2018
Auto merge of #21193 - servo:jdm-patch-17, r=asajeffrey
8866491 
Recreate virtualenv from scratch when syncing WPT

This fixes #21180 and attempts to work around #21145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21193)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 8084cf8 with merge 8866491...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 17, 2018
@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 8866491 to master...

@bors-servo bors-servo merged commit 8084cf8 into master Jul 17, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 17, 2018
@SimonSapin SimonSapin deleted the jdm-patch-17 branch August 8, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf test is broken
5 participants
@jdm @highfive @asajeffrey @bors-servo @avadacatavra