Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor run_in_headless_android_emulator.py out of mach test-android-startup #21200

Merged
merged 1 commit into from Jul 18, 2018
Merged

Refactor run_in_headless_android_emulator.py out of mach test-android-startup #21200

merged 1 commit into from Jul 18, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 18, 2018 •
edited

… and make it more careful about not leaving zombie processes behind.

This change is Reviewable
@nox nox changed the title Refactor run_in_headless_android_emulator.py out of mach test-androi-startup Refactor run_in_headless_android_emulator.py out of mach test-android-startup Jul 18, 2018
@nox
Copy link
Member

nox commented Jul 18, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

📌 Commit d58624c has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

⌛ Testing commit d58624c with merge 5beff25...
bors-servo added a commit that referenced this pull request Jul 18, 2018
@bors-servo
Auto merge of #21200 - servo:run_in_headless_android, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5beff25 
Refactor run_in_headless_android_emulator.py out of mach test-android-startup

… and make it more careful about not leaving zombie processes behind.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21200)
<!-- Reviewable:end -->
@SimonSapin
Refactor run_in_headless_android_emulator.py out of mach test-androi-…
Loading status checks…
5d416e6 
…startup

… and make it more careful about not leaving zombie processes behind.
@SimonSapin SimonSapin force-pushed the run_in_headless_android branch from d58624c to 5d416e6 Jul 18, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 18, 2018

Oops I accidentally removed adb install while refactoring. The test still worked on my machine because the APK was already installed from a previous run. Fixed that and added -wipe-data so that each run starts from a blank image.

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

📌 Commit 5d416e6 has been approved by nox
bors-servo added a commit that referenced this pull request Jul 18, 2018
@bors-servo
Auto merge of #21200 - servo:run_in_headless_android, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cc2fe91 
Refactor run_in_headless_android_emulator.py out of mach test-android-startup

… and make it more careful about not leaving zombie processes behind.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21200)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

⌛ Testing commit 5d416e6 with merge cc2fe91...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

💔 Test failed - linux-rel-css
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 18, 2018

Failures of all kinds in 567 different tests…

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing cc2fe91 to master...
@bors-servo bors-servo merged commit 5d416e6 into master Jul 18, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jul 18, 2018
Merged
Merged
@SimonSapin SimonSapin deleted the run_in_headless_android branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @nox @bors-servo @highfive
You can’t perform that action at this time.