Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflicts with anything that runs after test-perf. #21210

Closed
wants to merge 1 commit into from
Closed

Avoid conflicts with anything that runs after test-perf. #21210

wants to merge 1 commit into from
+3 −0

Conversation

@jdm
Copy link
Member

jdm commented Jul 19, 2018 •
edited by SimonSapin

r? @asajeffrey

This change is Reviewable
@jdm
Avoid conflicts with anything that runs after test-perf.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a912ae
@highfive
Copy link

highfive commented Jul 19, 2018

Heads up! This PR modifies the following files:
@aneeshusa
aneeshusa reviewed Jul 20, 2018
View changes
Copy link
Member

aneeshusa left a comment

I'd prefer doing everything from the activate onwards in a subshell, in case one of the intermediate commands errors and errexit causes us to exit before the deactivate can run.
@asajeffrey
Copy link
Member

asajeffrey commented Jul 20, 2018

Oh, does buildbot not isolate jobs? Perhaps it would be better not to activate the venv in the first place, and use a $PYTHON env var to tell run-warc-tests.sh where to find its python?
@jdm jdm closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa

Assignees

@asajeffrey asajeffrey

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @asajeffrey @aneeshusa
You can’t perform that action at this time.